Skip to content

Commit 289c4ae

Browse files
Refactor test_configure_highlightthickness.
1 parent bfd47d1 commit 289c4ae

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

Lib/test/test_tkinter/test_widgets.py

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,7 @@ def test_configure_labelwidget(self):
144144

145145
class AbstractLabelTest(AbstractWidgetTest, IntegerSizeTests):
146146
_conv_pixels = False
147-
148-
def test_configure_highlightthickness(self):
149-
widget = self.create()
150-
self.checkPixelsParam(widget, 'highlightthickness',
151-
0, 1.3, 2.6, 6, -2, '10p')
147+
clip_highlightthickness = False
152148

153149

154150
@add_standard_options(StandardOptionsTests)
@@ -280,6 +276,7 @@ class MenubuttonTest(AbstractLabelTest, unittest.TestCase):
280276
'underline', 'width', 'wraplength',
281277
)
282278
_conv_pixels = round
279+
clip_highlightthickness = True
283280

284281
def create(self, **kwargs):
285282
return tkinter.Menubutton(self.root, **kwargs)
@@ -293,9 +290,6 @@ def test_configure_height(self):
293290
widget = self.create()
294291
self.checkIntegerParam(widget, 'height', 100, -100, 0, conv=str)
295292

296-
test_configure_highlightthickness = \
297-
StandardOptionsTests.test_configure_highlightthickness
298-
299293
def test_configure_image(self):
300294
widget = self.create()
301295
image = tkinter.PhotoImage(master=self.root, name='image1')
@@ -1482,6 +1476,7 @@ class MessageTest(AbstractWidgetTest, unittest.TestCase):
14821476
_conv_pad_pixels = False
14831477
if tk_version >= (8, 7):
14841478
_conv_pixels = False
1479+
clip_highlightthickness = False
14851480

14861481
def create(self, **kwargs):
14871482
return tkinter.Message(self.root, **kwargs)
@@ -1490,14 +1485,6 @@ def test_configure_aspect(self):
14901485
widget = self.create()
14911486
self.checkIntegerParam(widget, 'aspect', 250, 0, -300)
14921487

1493-
def test_configure_highlightthickness(self):
1494-
widget = self.create()
1495-
self.checkPixelsParam(widget, 'highlightthickness',
1496-
0, 1.3, 2.6, 6, '10p')
1497-
expected = -2 if tk_version >= (8, 7) else 0
1498-
self.checkParam(widget, 'highlightthickness', -2, expected=expected,
1499-
conv=self._conv_pad_pixels)
1500-
15011488

15021489
class DefaultRootTest(AbstractDefaultRootTest, unittest.TestCase):
15031490

Lib/test/test_tkinter/widget_tests.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ class AbstractWidgetTest(AbstractTkTest):
1313
_conv_pixels = round
1414
_conv_pad_pixels = None
1515
_stringify = False
16+
clip_highlightthickness = True
1617

1718
@property
1819
def scaling(self):
@@ -305,7 +306,8 @@ def test_configure_highlightthickness(self):
305306
widget = self.create()
306307
self.checkPixelsParam(widget, 'highlightthickness',
307308
0, 1.3, 2.6, 6, '10p')
308-
self.checkParam(widget, 'highlightthickness', -2, expected=0,
309+
expected = 0 if self.clip_highlightthickness else -2
310+
self.checkParam(widget, 'highlightthickness', -2, expected=expected,
309311
conv=self._conv_pixels)
310312

311313
def test_configure_image(self):

0 commit comments

Comments
 (0)