Skip to content

Commit 1376d46

Browse files
committed
gh-109276: regrtest: shorter list of resources
1 parent bfe7e72 commit 1376d46

File tree

2 files changed

+33
-17
lines changed

2 files changed

+33
-17
lines changed

Lib/test/libregrtest/cmdline.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import shlex
44
import sys
55
from test.support import os_helper
6+
from .utils import ALL_RESOURCES, RESOURCE_NAMES
67

78

89
USAGE = """\
@@ -130,19 +131,6 @@
130131
"""
131132

132133

133-
ALL_RESOURCES = ('audio', 'curses', 'largefile', 'network',
134-
'decimal', 'cpu', 'subprocess', 'urlfetch', 'gui', 'walltime')
135-
136-
# Other resources excluded from --use=all:
137-
#
138-
# - extralagefile (ex: test_zipfile64): really too slow to be enabled
139-
# "by default"
140-
# - tzdata: while needed to validate fully test_datetime, it makes
141-
# test_datetime too slow (15-20 min on some buildbots) and so is disabled by
142-
# default (see bpo-30822).
143-
RESOURCE_NAMES = ALL_RESOURCES + ('extralargefile', 'tzdata')
144-
145-
146134
class Namespace(argparse.Namespace):
147135
def __init__(self, **kwargs) -> None:
148136
self.ci = False

Lib/test/libregrtest/utils.py

Lines changed: 32 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,19 @@
3333
EXIT_TIMEOUT = 120.0
3434

3535

36+
ALL_RESOURCES = ('audio', 'curses', 'largefile', 'network',
37+
'decimal', 'cpu', 'subprocess', 'urlfetch', 'gui', 'walltime')
38+
39+
# Other resources excluded from --use=all:
40+
#
41+
# - extralagefile (ex: test_zipfile64): really too slow to be enabled
42+
# "by default"
43+
# - tzdata: while needed to validate fully test_datetime, it makes
44+
# test_datetime too slow (15-20 min on some buildbots) and so is disabled by
45+
# default (see bpo-30822).
46+
RESOURCE_NAMES = ALL_RESOURCES + ('extralargefile', 'tzdata')
47+
48+
3649
# Types for types hints
3750
StrPath = str
3851
TestName = str
@@ -550,14 +563,29 @@ def display_header(use_resources: tuple[str, ...],
550563
if process_cpu_count and process_cpu_count != cpu_count:
551564
cpu_count = f"{process_cpu_count} (process) / {cpu_count} (system)"
552565
print("== CPU count:", cpu_count)
553-
print("== encodings: locale=%s, FS=%s"
566+
print("== encodings: locale=%s FS=%s"
554567
% (locale.getencoding(), sys.getfilesystemencoding()))
555568

556569
if use_resources:
557-
print(f"== resources ({len(use_resources)}): "
558-
f"{', '.join(sorted(use_resources))}")
570+
# Express resources related to "all"
571+
all_minus = [name for name in ALL_RESOURCES
572+
if name not in use_resources]
573+
all_minus.insert(0, 'all')
574+
all_minus = ',-'.join(all_minus)
575+
all_add = [name for name in use_resources
576+
if name not in ALL_RESOURCES]
577+
all_add.insert(0, all_minus)
578+
all_add = ','.join(all_add)
579+
all_text = f"resources: {all_add}"
580+
581+
text = ', '.join(sorted(use_resources))
582+
text = f"resources ({len(use_resources)}): {text}"
583+
if len(all_text) <= len(text):
584+
text = all_text
585+
print(f"== {text}")
559586
else:
560-
print("== resources: (all disabled, use -u option)")
587+
print("== resources: all test resources are disabled, "
588+
"use -u option to unskip tests")
561589

562590
cross_compile = is_cross_compiled()
563591
if cross_compile:

0 commit comments

Comments
 (0)