pysqlite_statement_reset result() is never used => return void

Author: Erlend E. Aasland

Modules/_sqlite/cursor.c

@@ -117,7 +117,7 @@ cursor_dealloc(pysqlite_Cursor *self)
         PyObject_ClearWeakRefs((PyObject*)self);
     }
     if (self->statement) {
-        (void)pysqlite_statement_reset(self->statement);
+        pysqlite_statement_reset(self->statement);
     }
     tp->tp_clear((PyObject *)self);
     tp->tp_free(self);
@@ -565,7 +565,7 @@ _pysqlite_query_execute(pysqlite_Cursor* self, int multiple, PyObject* operation
             break;
         }
 
-        (void)pysqlite_statement_reset(self->statement);
+        pysqlite_statement_reset(self->statement);
         pysqlite_statement_mark_dirty(self->statement);
 
         pysqlite_statement_bind_parameters(state, self->statement, parameters);

Modules/_sqlite/statement.c

@@ -360,19 +360,20 @@ pysqlite_statement_bind_parameters(pysqlite_state *state,
     }
 }
 
-int pysqlite_statement_reset(pysqlite_Statement* self)
+void
+pysqlite_statement_reset(pysqlite_Statement *self)
 {
     sqlite3_stmt *stmt = self->st;
     if (stmt == NULL || self->in_use == 0) {
-        return SQLITE_OK;
+        return;
     }
 
 #if SQLITE_VERSION_NUMBER >= 3020000
     /* Check if the statement has been run (that is, sqlite3_step() has been
      * called at least once). Third parameter is non-zero in order to reset the
      * run count. */
     if (sqlite3_stmt_status(stmt, SQLITE_STMTSTATUS_RUN, 1) == 0) {
-        return SQLITE_OK;
+        return;
     }
 #endif
 
@@ -384,7 +385,6 @@ int pysqlite_statement_reset(pysqlite_Statement* self)
     if (rc == SQLITE_OK) {
         self->in_use = 0;
     }
-    return rc;
 }
 
 void pysqlite_statement_mark_dirty(pysqlite_Statement* self)

Modules/_sqlite/statement.h

@@ -44,7 +44,7 @@ void pysqlite_statement_bind_parameters(pysqlite_state *state,
                                         pysqlite_Statement *self,
                                         PyObject *parameters);
 
-int pysqlite_statement_reset(pysqlite_Statement* self);
+void pysqlite_statement_reset(pysqlite_Statement *self);
 void pysqlite_statement_mark_dirty(pysqlite_Statement* self);
 
 int pysqlite_statement_setup_types(PyObject *module);