Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to specify mock #702

Merged
merged 1 commit into from
Feb 6, 2023
Merged

No need to specify mock #702

merged 1 commit into from
Feb 6, 2023

Conversation

jeffwidman
Copy link
Member

It's now part of the Python stdlib since 3.3.

So no need to specify it.

@a-ungurianu
Copy link
Member

mock is indeed available in stdlib, but it's under unittest.mock

houndci-bot
houndci-bot reviewed Jan 31, 2023
View reviewed changes
kazoo/tests/test__connection.py Outdated Show resolved Hide resolved
kazoo/tests/test_partitioner.py Outdated Show resolved Hide resolved
kazoo/tests/test_partitioner.py Outdated Show resolved Hide resolved
@jeffwidman jeffwidman force-pushed the stop-specifying-mock branch 2 times, most recently from 4b4549f to 31bb1b8 Compare January 31, 2023 21:44
@jeffwidman
Copy link
Member Author

Thanks @a-ungurianu, I threw this PR up quickly from web UI and then completely forgot about it!

@jeffwidman jeffwidman marked this pull request as draft January 31, 2023 22:06
jeffwidman added a commit that referenced this pull request Jan 31, 2023
@jeffwidman
debug: try bumping mock version
ba1eb4f 
Seeing a weird error in #702 and wondering if it's because latest `mock` is actually `5.0.1`: https://mock.readthedocs.io/en/latest/changelog.html

so threw this up to see what CI thinks
@jeffwidman jeffwidman mentioned this pull request Jan 31, 2023
Closed
@jeffwidman jeffwidman force-pushed the stop-specifying-mock branch 3 times, most recently from 6d53733 to d2e0aaf Compare January 31, 2023 22:25
@jeffwidman jeffwidman marked this pull request as ready for review January 31, 2023 22:26
@codecov
Copy link

codecov bot commented Jan 31, 2023 •
edited
Loading

Codecov Report

Base: 94.63% // Head: 94.71% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (6d53733) compared to base (bcc9685).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 6d53733 differs from pull request most recent head 064fed0. Consider uploading reports for the commit 064fed0 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   94.63%   94.71%   +0.07%     
==========================================
  Files          57       57              
  Lines        8339     8332       -7     
==========================================
  Hits         7892     7892              
+ Misses        447      440       -7
Impacted Files Coverage Δ
kazoo/tests/conftest.py 100.00% <ø> (+62.50%) ⬆️
kazoo/tests/test__connection.py 98.14% <100.00%> (+0.37%) ⬆️
kazoo/tests/test_cache.py 59.18% <100.00%> (-0.35%) ⬇️
kazoo/tests/test_client.py 98.80% <100.00%> (+0.09%) ⬆️
kazoo/tests/test_lock.py 98.78% <100.00%> (ø)
kazoo/tests/test_partitioner.py 98.69% <100.00%> (ø)
kazoo/tests/test_threading_handler.py 96.18% <100.00%> (ø)
kazoo/tests/test_utils.py 93.33% <100.00%> (ø)
kazoo/handlers/utils.py 94.06% <0.00%> (-0.46%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeffwidman
Copy link
Member Author

This is ready for review. The miniscule drop in coverage is a side effect of changing imports and shouldn't block merging.

@jeffwidman
refactor: no need to specify mock
064fed0 
It's now part of the Python stdlib since `3.3`.

So no need to specify it.
@jeffwidman
Copy link
Member Author

Can I please get a review on this so we can land it before merge conflicts creep in?

StephenSorriaux
StephenSorriaux approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeffwidman jeffwidman merged commit 92b071d into master Feb 6, 2023
@jeffwidman jeffwidman deleted the stop-specifying-mock branch February 6, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@StephenSorriaux StephenSorriaux StephenSorriaux approved these changes

@ceache ceache Awaiting requested review from ceache

@a-ungurianu a-ungurianu Awaiting requested review from a-ungurianu

@bbangert bbangert Awaiting requested review from bbangert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffwidman @a-ungurianu @houndci-bot @StephenSorriaux