fix(handlers): make AsyncResult call all registered callbacks instantly if the handler has stopped running #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-surcel
changed the title
| @@ -122,6 +113,18 @@ def unlink(self, callback): | |||
| if callback in self._callbacks: | |||
| self._callbacks.remove(callback) | |||
|
|
|||
| def _do_callbacks(self): | |||
There was a problem hiding this comment.
Can you please add a little description to this method? Just to help make the read straightforward for any newcomer.
There was a problem hiding this comment.
Sure. I'll add one. I'll also look into adding a test for it.
There was a problem hiding this comment.
Done. It's some simple test but it showcases what was happening in my case. It's more complicated to do a functional test that can actually reproduce the situation when a response is received just after stop was called, But this test will fail without my changes and pass with them.
…ly if the handler has stoppped running
laura-surcel
force-pushed
the
deadlock-fix
branch
from
eb1ef5d to
c244320
Compare
StephenSorriaux
approved these changes
Jan 15, 2019
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm using kazoo in a work-related project and sometimes our tests are leaving zombie threads that are blocked in
self._condition.wait(timeout)fromAsyncResult:get.After some digging it looks like the problem occurs when we start a KazooClient, try to make an operation on it like a path creation and then stop it fast. In this case, the callbacks of the
AsyncResultmay not be called ifAsyncResult:set/AsyncResult:set_exceptionare called just after the client is stopped. As I said it might not happen too often for most people but for us it's like in 10% of the test runs and it's slows down our development pipeline. I've made a customAyncResultclass in our project that modifies a bit the behavior and seems to fix the issue for us but maybe you guys would also consider this solution for the official version.If you have other suggestions or concerns let me know.