Counter: expose the previous and changed values. #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the `Counter` API with the `pre_value` and `post_value` attributes. These attributes are set when a counter is changed. Previously, if the counter was modified concurrently, it was not possible to access the exact value to which the counter was set after a successful increment or decrement.
|
This is inspired by the API provided by http://curator.apache.org/curator-recipes/distributed-atomic-long.html |
|
Ping @hannosch |
|
@neuroid sorry, I'm not actively contributing to kazoo anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the
CounterAPI with thepre_valueandpost_valueattributes. These attributes are set when a counteris changed. Previously, if the counter was modified concurrently,
it was not possible to access the exact value to which the counter
was set after a successful increment or decrement.