-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify lock recipe in a post Python 3.2 threading world. #605
Comments
Do you think starting a |
I certainly would support simplifying this code. I'd suggest doing it in pieces... ie, this is an obvious candidate for a PR all by itself. Doing it as a separate branch with such a broad scope of "drop all python 2 support" is a much bigger task... |
Just wanted to say thanks @ceache and @StephenSorriaux for all the efforts that you've been landing lately, including this. |
The lock recipe assumes
threading.Lock.acquire()
does not take a timeout argument.kazoo/kazoo/recipe/lock.py
Line 173 in b20c929
https://docs.python.org/3/library/threading.html#threading.Lock.acquire
Code can be simplified a lot now that Py2x and py3 < 3.6 support is dropped.
(Note that Gevent and Eventlet Lock already have a timeout argument)
The text was updated successfully, but these errors were encountered: