Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataWatch is using TypeError to detect the arity of callback function #475

Open
liudangyi opened this issue Aug 23, 2017 · 0 comments
Open

Comments

@liudangyi
Copy link

In kazoo/recipe/watchers.py line 163.

            try:
                result = self._func(data, stat, event)
            except TypeError:
                result = self._func(data, stat)

It's too terrible since a lot of error could raise a TypeError. Two better ways may be

  1. Like ChildrenWatch, add a send_event parameter.
  2. Use len(inspect.getargspec(self._func).args) to decide the arity first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants