modernize packaging #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
force-pushed
the
33-modernize-packaging
branch
from
97c4363 to
159b5bb
Compare
dhellmann
force-pushed
the
33-modernize-packaging
branch
2 times, most recently
from
b5a4a6e to
63ca657
Compare
- Replace pbr with setuptools, setuptools_scm, and build. - Move most of the packaging settings into pyproject.toml. - Update tox settings to reflect packaging changes. - Update documentation build version detection. - Update documentation for entry points now that setup.cfg is removed. Fixes python-virtualenvwrapper#33 Addresses python-virtualenvwrapper#34
The tests were always running the local source copy of virtualenvwrapper.sh, which does not ensure we are packaging and installing that file properly. This commit changes the logic for loading the wrappers so when the job is running under tox we always look in the virtualenv's bin directory.
We will want something nicer, but without pbr we don't get this generated content for free so this commit initializes the static content. Addresses python-virtualenvwrapper#36
dhellmann
force-pushed
the
33-modernize-packaging
branch
from
6e4beca to
2fe0f73
Compare
|
@jasonamyers I think this is ready for review. |
jasonamyers
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Addresses #34
Addresses #36