.onion TLD

[davidt99]

When validating URLs with TLD enabled, .onion comes up as not validated. Since .onion URLs (TOR) are kinda unique, I wonder if we should add it to the TLD list or add a separate flag.
I can open a PR for both solutions, I just wonder what the best way is.
For context, tldextract accepts .onion.

[yozachar]

Hi @davidt99, are onion URLs validated by this library? Can you show me an example? AFAIK they are not in tests.

[davidt99]

It's not validated when the consider_tld flag is on since .onion is not in the TLD list.

[yozachar]

Okay, instead of adding it to _tld.txt, we could append it to _popular_cache in domain.py.

_popular_cache = {"COM", "ORG", "RU", "DE", "NET", "BR", "UK", "JP", "FR", "IT"}
_popular_cache.add("ONION")