-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harden lazy wheel wheel error handling #9051
Conversation
2276267
to
713c245
Compare
Great job! Thank you a lot for fixing this! :) |
713c245
to
9f39259
Compare
#9056 looks as though it provides another instance of the LazyWheel code making optimistic assertions about server behaviour, dunno whether it makes sense to handle that in this pull request or separately
|
I reckon another PR might be better largely because I do not want to hold this up too long since this will in-effect solve that as well, or make it not impact UX. But might be good to have a targeted fix for defense-in-depth measure. |
This change attempts to provide a catch-all safety net for circumstances where an index server is behaving badly when ranged requests are made. Additionally, this change also helps guard against missing "Content-Range" headers in specific scenarios.
9f39259
to
8cfb9ee
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This change attempts to provide a catch-all safety net for circumstances where an index server is behaving badly when ranged requests are made.
Additionally, this change also helps guard against missing "Content-Range" headers in specific scenarios.
Resolves: #9042
Mitigtates: #9056