Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --next-phase command to poetry version #8089

Merged
merged 11 commits into from
Sep 10, 2023

Conversation

nfnvsc
Copy link
Contributor

@nfnvsc nfnvsc commented Jun 11, 2023

Pull Request Check List

Resolves: #1959

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR include a new flag --next-phase for the poetry version command, which will only have impact when using the prerelease argument.

The behaviour of --next-phase is to increment the phase of the current version eg:

Current Version Command Updated Version
1.2.3a0 poetry version prerelease --next-phase 1.2.3b0
1.2.3b0 poetry version prerelease 1.2.3b1
1.2.3b1 poetry version prerelease --next-phase 1.2.3rc0
1.2.3rc0 poetry version prerelease 1.2.3rc1
1.2.3rc1 poetry version prerelease --next-phase 1.2.3

From my perspective this is the most correct way to handle the phases of the prereleases as defined by poetry-core version module.

@nfnvsc nfnvsc marked this pull request as ready for review June 11, 2023 15:36
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there has been only positive feedback in #1959 so far, I think we can proceed.

The PR looks good in general, I just like to have another test that passes the command line parameter.

docs/cli.md Outdated Show resolved Hide resolved
@nfnvsc
Copy link
Contributor Author

nfnvsc commented Sep 10, 2023

Aligned the documentation table and added a new test with the command line parameter as requested @radoering

tests/console/commands/test_version.py Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
@radoering radoering added the impact/docs Contains or requires documentation changes label Sep 10, 2023
@github-actions
Copy link

Deploy preview for website ready!

✅ Preview
https://website-evspclk4f-python-poetry.vercel.app

Built with commit eca37f6.
This pull request is being automatically deployed with vercel-action

@radoering radoering merged commit 398523c into python-poetry:master Sep 10, 2023
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend poetry version xxx commands to support -beta.# and -rc.#
2 participants