-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export: replace in-tree implementation with poetry-plugin-export #5413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging this PR, there are some issues in poetry-plugin-export
that should be fixed. (Its tests ran against the old in-tree implementation!)
See python-poetry/poetry-plugin-export#50 for proposed changes.
However, the poetry-export-plugin
PR is blocked by #5435 which should be merged into master first. Then, this branch can be rebased and python-poetry/poetry-plugin-export#50 can be updated to pass the tests.
Further, there is a change in behavior that I am not sure is intentional: The in-tree export command did not export dev dependencies by default. There was even a test for that default behavior. The poetry-plugin-export
exports all non-optional dependencies (including dev-depdendencies) by default.
Thanks @radoering. Ugg; good catches. As for the beaviour change, I commented on the python-poetry/poetry-plugin-export#50. I need to take a closer look at #5435, first glance reminds of #5311 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there two open points that build on each other:
- decision on default behavior (including
--with/--without
handling), see latest changes in Fix 1.0.0 issues poetry-plugin-export#50 for the variant "no breaking change but different behavior of export command compared to install command" - update documentation (should be done after decision on default behavior was made) btw, the documentation has to remain in this repo?
|
Still needs to be done. |
Ack, will update. Until we have a better strategy for handling this, documentation should remain in this repo as the current website publishing only accounts for this repository. But, in the mid-term (outside of this PR), figure out how to get the website to also support any documentation we put in the plugin repository. The |
This is done to allow safe refactoring of export command plugin.
This change cleans up loading of plugins when testing commands.
This is no longer required and is superseded by the groups feature.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Once the export plugin code releases 1.x (python-poetry/poetry-plugin-export#46), this PR should add changes to replace the export command.
Closes: #4824
Depends-on: #5412Notes: