Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the site-packages directory detection #1683

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

sdispater
Copy link
Member

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Sometimes, the site-packages directory does not reside in the lib/pythonX.X directory but at the root of the virtual environment instead (seen in pypy3 virtual environments). This PR handles this case.

@sdispater sdispater added the area/venv Related to virtualenv management label Dec 6, 2019
@sdispater sdispater force-pushed the improve-site-packages-detection branch from 0eaaa44 to e236bc3 Compare December 6, 2019 14:54
@sdispater sdispater force-pushed the improve-site-packages-detection branch from e236bc3 to 316a838 Compare December 6, 2019 15:07
@sdispater sdispater merged commit 497cacd into master Dec 6, 2019
@sdispater sdispater deleted the improve-site-packages-detection branch December 6, 2019 15:38
shenek pushed a commit to shenek/poetry that referenced this pull request Dec 31, 2019
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/venv Related to virtualenv management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant