Backport fix for mismatching hash check #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #159 to poetry-core 1.0 as this is part of an important security fix.
See python-poetry/poetry#3885 and python-poetry/poetry#2422
I think that this fix exposes a preexisting bug in Poetry where
poetry install
fails with the following:I think that there is an underlying bug where an object that should be a
Path
is actually aLink
, and that is exposed by the fact that thePackage.files
attribute gets cloned, and not lost as of now in Poetry 1.1.8.