From 5d5251c427aacedcf54f9743635a8124e5a26151 Mon Sep 17 00:00:00 2001 From: Arun Babu Neelicattu Date: Tue, 6 Oct 2020 12:18:34 +0200 Subject: [PATCH] package: do not default to develop Setting develop to `True` by default causes un-expected side-effects and requires downstream consumers to rely on checks like `package.develop and package.source_type == "directory""` to determine if develop mode. This also corresponds to current high-level behaviour of packages being non-develop by default. --- poetry/core/packages/package.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/poetry/core/packages/package.py b/poetry/core/packages/package.py index cf972dae5..4a8152e60 100644 --- a/poetry/core/packages/package.py +++ b/poetry/core/packages/package.py @@ -49,7 +49,8 @@ def __init__( source_url: Optional[str] = None, source_reference: Optional[str] = None, source_resolved_reference: Optional[str] = None, - features: Optional[List[str]] = None, # type + features: Optional[List[str]] = None, + develop: bool = False, ) -> None: """ Creates a new in memory package. @@ -105,7 +106,7 @@ def __init__( self.root_dir = None - self.develop = True + self.develop = develop @property def name(self) -> str: