Raise an error if path is compacted during mapping#8416
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Oct 1, 2024
Merged
Raise an error if path is compacted during mapping#8416hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
e4bf1ea to
a99361a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within
path_map(), a Python function is called.Pillow/src/path.c
Lines 393 to 404 in 55a25aa
That Python function could, theoretically, make a call to
ImagePath.Path.compact(), akapath_compact(), reallocatingself->xy.Pillow/src/path.c
Line 300 in 55a25aa
It would then be incorrect for
xyto be accessed again bypath_map().I've added a flag to
PyPathObjectthat is set at the start of the mapping loop, and cleared at the end. If the user's custom Python function callscompact()to reallocate the array in the middle, then aValueErroris raised.