Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary pymode variable #8247

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary pymode variable #8247

wants to merge 1 commit into from

Conversation

Yay295
Copy link
Contributor

@Yay295 Yay295 commented Jul 19, 2024

The mode string can be directly passed to Py_BuildValue() as an "s" value instead of an "S" value where we need to convert it to a Python object ourselves.

@radarhere
Copy link
Member

radarhere commented Jul 20, 2024 •
edited
Loading

#8213 would remove this code altogether.

@Yay295
Copy link
Contributor Author

Yay295 commented Aug 14, 2024

#8213 removed this code.

@Yay295 Yay295 closed this Aug 14, 2024
@Yay295 Yay295 deleted the patch-3 branch August 14, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yay295 @radarhere