Added type hints to additional tests #8118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
commented
Jun 9, 2024
Tests/test_image_thumbnail.py
Outdated
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| def test_sanity() -> None: | |||
| im = hopper() | |||
| assert im.thumbnail((100, 100)) is None | |||
| assert im.thumbnail((100, 100)) is None # type: ignore[func-returns-value] | |||
There was a problem hiding this comment.
Without this ignore, mypy reports
Tests/test_image_thumbnail.py:19: error: "thumbnail" of "Image" does not return a value (it only ever returns None) [func-returns-value]
assert im.thumbnail((100, 100)) is None
^~~~~~~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
Couldn't this line just be im.thumbnail((100, 100)), without the assert?
There was a problem hiding this comment.
Ok, I’ve pushed a commit.
radarhere
commented
Jun 9, 2024
radarhere
force-pushed
the
type_hint_tests
branch
from
5ff7ce3 to
10647e6
Compare
radarhere
force-pushed
the
type_hint_tests
branch
from
10647e6 to
291ee35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.