Raise ValueError if kmeans is negative #7891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, shall we add a test that successfully calls |
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7890 (comment) found that if
kmeansif negative,im.quantize()can become stuck in an infinite loop.Investigating, I was able to reproduce this for
MEDIANCUTandMAXCOVERAGE.This PR updates the docstring to specify that
kmeansshould not be negative, raises a ValueError ifkmeansis negative, and to be safe, also updates the C code to not use negative kmeans either.