Match mask size to pasted image size in GifImagePlugin#7779
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Mar 1, 2024
Merged
Match mask size to pasted image size in GifImagePlugin#7779hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
alanhamlett
approved these changes
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7777
When looping through images to create a GIF image, the frames may be different sizes.
At the moment, this means that
Pillow/src/PIL/GifImagePlugin.py
Line 671 in 1b67239
fillcomes from the size of the new frame, whereasmaskcomes fromImageChops.subtract_modulo()between the new and the old frame.This may cause a mismatch in size between the image being pasted and the mask, which can lead to an error.