Replace `io.BytesIO` in type hints #7750

hugovk · 2024-01-23T21:07:16Z

Alternative to and closes #7737.

In type hints like fp: io.BytesIO, we should avoid the concrete io.BytesIO, and use more specific type hints to reflect what the file-like object actually does.

The one in GdImageFile.py is used in many ways, so has more complex hints; the one in MpegImagePlugin.py is used in fewer so is more focused.

This takes some type hints from typeshed:

I'm open to better suggestions for the docs in internal_modules.rst, like can we use automodule or something?

Four other plugins have BytesIO hints to replace, this PR deals with the two which block the docs build.

Thank you to @AlexWaygood for the advice!

AlexWaygood · 2024-01-23T21:56:30Z

src/PIL/_typing.py

+
+class SupportsRead(Protocol[_T_co]):
+    def read(self, __length: int = ...) -> _T_co:
+        ...


Looks like coverage is complaining about this line "not being covered by tests" — here's how we deal with this in CPython, FWIW: https://github.com/python/cpython/blob/d22c066b802592932f9eb18434782299e80ca42e/.coveragerc#L12

(I added the exclude when we started adding type hints to Argument Clinic ;)

AlexWaygood

LGTM!

nulano · 2024-01-25T21:31:33Z

src/PIL/_util.py



-def is_path(f: Any) -> TypeGuard[bytes | str | Path]:
+def is_path(f: Any) -> TypeGuard[StrOrBytesPath]:


Given that the function returns isinstance(f, (bytes, str, Path)), I'm not sure I understand the point of this change.
I haven't checked, but I think this will reintroduce a type warning in ImageFont here:

Pillow/src/PIL/ImageFont.py

Lines 232 to 236 in b3a7ae0

if is_path(font):

if isinstance(font, Path):

font = str(font)

if sys.platform == "win32":

font_bytes_path = font if isinstance(font, bytes) else font.encode()

Good point — I think I gave @hugovk bad (or at least incomplete) advice here.

I would probably consider refactoring the code you link to there in ImageFont.py so that it does handle any os.PathLike rather than specifically checking for pathlib.Path, and change this function so that it does isinstance(f, (str, bytes, os.PathLike)) instead of isinstance(f, (str, bytes, pathlib.Path)). But perhaps all that could be deferred to another PR

I haven't checked, but I think this will reintroduce a type warning in ImageFont here:

We haven't added type hints to ImageFont.py yet, it's giving 55 strict warnings for both main and this PR, and zero non-strict on both.

I would probably consider refactoring the code you link to there in ImageFont.py so that it does handle any os.PathLike rather than specifically checking for pathlib.Path, and change this function so that it does isinstance(f, (str, bytes, os.PathLike)) instead of isinstance(f, (str, bytes, pathlib.Path)). But perhaps all that could be deferred to another PR

I've updated this PR to include the refactor.

AlexWaygood · 2024-01-26T17:35:00Z

src/PIL/ImageFont.py

@@ -230,7 +230,7 @@ def load_from_bytes(f):
            )

        if is_path(font):
-            if isinstance(font, Path):
+            if isinstance(font, os.PathLike):
                font = str(font)


For pathlib.Paths, str(path_object) always produces what you want here, but that's not necessarily true for all os.PathLikes. You should use os.fspath here if you want the code to work with arbitrary PathLikes:

Suggested change

font = str(font)

font = os.fspath(font)

You can actually also pass str and bytes objects to os.fspath, so you could probably get rid of the isinstance(font, os.PathLike) check immediately above as well (I'm on my mobile so my suggestion can't span multiple lines :( )

Docs: https://docs.python.org/3/library/os.html#os.fspath

radarhere · 2024-01-27T06:14:59Z

src/PIL/_typing.py

+
+
+FileDescriptor = int
+StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]


Suggested change

StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]

StrOrBytesPath = Union[str, bytes, os.PathLike[str], os.PathLike[bytes]]

Why are the quotes helpful?

For Python 3.8 compatibility:

❯ python3.8 -m pytest Tests/test_util.py Traceback (most recent call last): File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/runpy.py", line 194, in _run_module_as_main return _run_code(code, main_globals, None, File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pytest/__main__.py", line 5, in <module> raise SystemExit(pytest.console_main()) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 192, in console_main code = main() File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 150, in main config = _prepareconfig(args, plugins) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 331, in _prepareconfig config = pluginmanager.hook.pytest_cmdline_parse( File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_hooks.py", line 493, in __call__ return self._hookexec(self.name, self._hookimpls, kwargs, firstresult) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_manager.py", line 115, in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_callers.py", line 130, in _multicall teardown[0].send(outcome) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/helpconfig.py", line 104, in pytest_cmdline_parse config: Config = outcome.get_result() File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_result.py", line 114, in get_result raise exc.with_traceback(exc.__traceback__) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_callers.py", line 77, in _multicall res = hook_impl.function(*args) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1075, in pytest_cmdline_parse self.parse(args) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1425, in parse self._preparse(args, addopts=addopts) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1327, in _preparse self.hook.pytest_load_initial_conftests( File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_hooks.py", line 493, in __call__ return self._hookexec(self.name, self._hookimpls, kwargs, firstresult) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_manager.py", line 115, in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_callers.py", line 152, in _multicall return outcome.get_result() File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_result.py", line 114, in get_result raise exc.with_traceback(exc.__traceback__) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pluggy/_callers.py", line 77, in _multicall res = hook_impl.function(*args) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1153, in pytest_load_initial_conftests self.pluginmanager._set_initial_conftests( File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 563, in _set_initial_conftests self._try_load_conftest(anchor, importmode, rootpath) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 580, in _try_load_conftest self._getconftestmodules(anchor, importmode, rootpath) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 609, in _getconftestmodules mod = self._importconftest(conftestpath, importmode, rootpath) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 657, in _importconftest self.consider_conftest(mod) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 739, in consider_conftest self.register(conftestmodule, name=conftestmodule.__file__) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 498, in register self.consider_module(plugin) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 747, in consider_module self._import_plugin_specs(getattr(mod, "pytest_plugins", [])) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 754, in _import_plugin_specs self.import_plugin(import_spec) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 781, in import_plugin __import__(importspec) File "<frozen importlib._bootstrap>", line 991, in _find_and_load File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 671, in _load_unlocked File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 178, in exec_module exec(co, module.__dict__) File "/Users/hugo/github/Pillow/Tests/helper.py", line 19, in <module> from PIL import Image, ImageMath, features File "/Users/hugo/github/Pillow/src/PIL/Image.py", line 61, in <module> from ._util import DeferredError, is_path File "/Users/hugo/github/Pillow/src/PIL/_util.py", line 7, in <module> from ._typing import StrOrBytesPath, TypeGuard File "/Users/hugo/github/Pillow/src/PIL/_typing.py", line 29, in <module> StrOrBytesPath = Union[str, bytes, os.PathLike[str], os.PathLike[bytes]] TypeError: 'ABCMeta' object is not subscriptable

❯ python3.8 Python 3.8.10 (v3.8.10:3d8993a744, May 3 2021, 09:09:08) [Clang 12.0.5 (clang-1205.0.22.9)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import os >>> os.PathLike[str] Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: 'ABCMeta' object is not subscriptable

❯ python3.9 Python 3.9.13 (v3.9.13:6de2ca5339, May 17 2022, 11:37:23) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import os >>> os.PathLike[str] os.PathLike[str] >>> type(os.PathLike[str]) <class 'types.GenericAlias'>

types.GenericAlias is new in Python 3.9:

https://docs.python.org/3/whatsnew/3.9.html#collections-abc

So we can drop the quotes in October when 3.8 goes EOL.

Shall we do this, so pyupgrade catches it when we drop 3.8?

Suggested change

StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]

if sys.version_info >= (3, 9):

StrOrBytesPath = Union[str, bytes, os.PathLike[str], os.PathLike[bytes]]

else:

StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]

Not sure how the typing-extensions dependency is managed on Pillow, but TypeAlias could be used as well:

StrOrBytesPath: TypeAlias = "str | bytes | os.PathLike[str] | os.PathLike[bytes]"

Similar to TypeGuard, a "dummy" implementation of TypeAlias could be added in _typing.py?

Maybe you're already aware but TypeAlias was only added in Python 3.10 - https://docs.python.org/3/library/typing.html#typing.TypeAlias

I'm personally fine with the current version. We can just remove the quotes by hand in October when Python 3.8 is EOL.

Yeah that's why I suggested adding it similarly to TypeGuard. But yes probably not worth for just a few months

AlexWaygood · 2024-01-27T11:09:14Z

Some other changes that you might need to make elsewhere for proper support for arbitrary non-pathlib os.PathLikes:

diff --git a/docs/reference/open_files.rst b/docs/reference/open_files.rst
index f31941c9a..d617ae9ae 100644
--- a/docs/reference/open_files.rst
+++ b/docs/reference/open_files.rst
@@ -3,7 +3,7 @@
 File Handling in Pillow
 =======================

-When opening a file as an image, Pillow requires a filename, ``pathlib.Path``
+When opening a file as an image, Pillow requires a filename, `os.PathLike``
 object, or a file-like object. Pillow uses the filename or ``Path`` to open a
 file, so for the rest of this article, they will all be treated as a file-like
 object.
diff --git a/src/PIL/Image.py b/src/PIL/Image.py
index 553f36703..48125b317 100644
--- a/src/PIL/Image.py
+++ b/src/PIL/Image.py
@@ -39,7 +39,6 @@ import tempfile
 import warnings
 from collections.abc import Callable, MutableMapping
 from enum import IntEnum
-from pathlib import Path

 try:
     from defusedxml import ElementTree
@@ -2370,7 +2369,7 @@ class Image:
         implement the ``seek``, ``tell``, and ``write``
         methods, and be opened in binary mode.

-        :param fp: A filename (string), pathlib.Path object or file object.
+        :param fp: A filename (string), os.PathLike object or file object.
         :param format: Optional format override.  If omitted, the
            format to use is determined from the filename extension.
            If a file object was used instead of a filename, this
@@ -2385,11 +2384,8 @@ class Image:

         filename = ""
         open_fp = False
-        if isinstance(fp, Path):
-            filename = str(fp)
-            open_fp = True
-        elif is_path(fp):
-            filename = fp
+        if is_path(fp):
+            filename = os.fspath(fp)
             open_fp = True
         elif fp == sys.stdout:
             try:
@@ -3206,7 +3202,7 @@ def open(fp, mode="r", formats=None) -> Image:
     :py:meth:`~PIL.Image.Image.load` method).  See
     :py:func:`~PIL.Image.new`. See :ref:`file-handling`.

-    :param fp: A filename (string), pathlib.Path object or a file object.
+    :param fp: A filename (string), os.PathLike object or a file object.
        The file object must implement ``file.read``,
        ``file.seek``, and ``file.tell`` methods,
        and be opened in binary mode. The file object will also seek to zero
@@ -3244,8 +3240,8 @@ def open(fp, mode="r", formats=None) -> Image:

     exclusive_fp = False
     filename = ""
-    if isinstance(fp, Path):
-        filename = str(fp.resolve())
+    if isinstance(fp, os.PathLike):
+        filename = os.path.realpath(os.fspath(fp))
     elif is_path(fp):
         filename = fp

hugovk · 2024-01-27T12:06:40Z

Thanks, updated!

src/PIL/_util.py

Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>

for more information, see https://pre-commit.ci

AlexWaygood · 2024-02-07T08:58:48Z

src/PIL/_typing.py

@@ -29,4 +32,4 @@ def read(self, __length: int = ...) -> _T_co:
 StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]


-__all__ = ["FileDescriptor", "TypeGuard", "StrOrBytesPath", "SupportsRead"]


Looks like something might have gone wrong in the merge commit here; I don't think these new symbols should have been removed from __all__ as part of the merge in 05506e5?

Oh, my bad. I've force-pushed a fixed merge commit.

AlexWaygood · 2024-02-07T09:20:50Z

src/PIL/_typing.py

+FileDescriptor = int
+StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]
+
+
 __all__ = ["TypeGuard"]


To address #7750 (comment):

Suggested change

__all__ = ["TypeGuard"]

__all__ = ["FileDescriptor", "TypeGuard", "StrOrBytesPath", "SupportsRead"]

I've made this change.

radarhere · 2024-02-08T07:44:29Z

src/PIL/GdImageFile.py

@@ -80,7 +81,9 @@ def _open(self) -> None:
        ]


-def open(fp: BytesIO, mode: str = "r") -> GdImageFile:
+def open(
+    fp: StrOrBytesPath | FileDescriptor | IO[bytes], mode: str = "r"


fp is used to create GdImageFile through its parent ImageFile, and is then handled by

Pillow/src/PIL/ImageFile.py

Lines 123 to 133 in 6782a07

if is_path(fp):

# filename

self.fp = open(fp, "rb")

self.filename = fp

self._exclusive_fp = True

else:

# stream

self.fp = fp

self.filename = filename

# can be overridden

self._exclusive_fp = None

I'm not seeing how it would successfully handle FileDescriptor?

Good point, if you wanted to also handle file descriptors, you'd need to change line 123 of ImageFile.py to:

if is_path(fp) or isinstance(fp, int):

GdImageFile is not exactly the most used image plugin, so I don't think we need to be adding new functionality for it.

I've created hugovk#113 to remove the FileDescriptor.

Yeah, this was my mistake — I think I misread something. Agree that supporting file descriptors isn't really necessary

docs/reference/internal_modules.rst

Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>

radarhere · 2024-02-11T04:45:49Z

.coveragerc

@@ -10,6 +10,9 @@ exclude_also =
    if DEBUG:
    # Don't complain about compatibility code for missing optional dependencies
    except ImportError
+    # Empty bodies in protocols or abstract methods
+    ^\s*def [a-zA-Z0-9_]+\(.*\)(\s*->.*)?:\s*\.\.\.(\s*#.*)?$
+    ^\s*\.\.\.(\s*#.*)?$


My only concern is licensing/permission as this code comes from somewhere else. However, it is in both https://github.com/python/cpython/blob/main/.coveragerc and https://chromium.googlesource.com/external/github.com/python/cpython/+/05e47202a34e6ae05e699af1083455f5b8b59496/.coveragerc, so it may not be unique.

IANAL, but my understanding is that you can't copyright code when it is the only (or one of a small number of) obvious solution, which would cover this Regex (I can think of two small changes I might have made if I was making it from scratch, but it is likely possible to enumerate all reasonable solutions on a single page).

radarhere · 2024-02-13T11:39:44Z

Four other plugins have BytesIO hints to replace

I've created #7795 for this.

Replace io.BytesIO in type hints

231d54b

hugovk added the Type hints label Jan 23, 2024

AlexWaygood reviewed Jan 23, 2024

View reviewed changes

AlexWaygood approved these changes Jan 23, 2024

View reviewed changes

Exclude from coverage: empty bodies in protocols or abstract methods

e3932b7

nulano reviewed Jan 25, 2024

View reviewed changes

hugovk added 3 commits January 26, 2024 19:17

Handle os.PathLike in is_path

9452536

Parameterise test

f613a92

Test os.PathLike that's not pathlib.Path

16d4068

AlexWaygood reviewed Jan 26, 2024

View reviewed changes

Use os.fspath instead of isinstance and str

d631afc

radarhere reviewed Jan 27, 2024

View reviewed changes

More support for arbitrary os.PathLike

61d47c3

hugovk and others added 2 commits January 28, 2024 11:22

Merge branch 'main' into type-hints-replace-io.BytesIO

d49d2d1

Merge branch 'main' into type-hints-replace-io.BytesIO

530512f

nulano reviewed Jan 31, 2024

View reviewed changes

src/PIL/_util.py Outdated Show resolved Hide resolved

hugovk and others added 2 commits January 31, 2024 12:37

Replace bytes | str | Path with StrOrBytesPath

f2228e0

Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>

[pre-commit.ci] auto fixes from pre-commit.com hooks

256f3f1

for more information, see https://pre-commit.ci

AlexWaygood reviewed Feb 7, 2024

View reviewed changes

Merge branch 'main' into type-hints-replace-io.BytesIO

159fc06

radarhere force-pushed the type-hints-replace-io.BytesIO branch from 2d5ca15 to 159fc06 Compare February 7, 2024 09:50

radarhere reviewed Feb 8, 2024

View reviewed changes

radarhere added 2 commits February 8, 2024 18:48

Use _typing alias

a276cf2

Use os.path.realpath consistently when os.fspath is used

a118a82

This was referenced Feb 8, 2024

Use os.path.realpath consistently when os.fspath is used hugovk/Pillow#112

Merged

Add BytesIO alias to fix missing references in docs #7737

Closed

Simplified code

152a24e

hugovk and others added 2 commits February 10, 2024 11:43

Merge pull request #112 from radarhere/type-hints-replace-io.BytesIO

958a651

Removed FileDescriptor

517b797

radarhere mentioned this pull request Feb 10, 2024

Removed FileDescriptor hugovk/Pillow#113

Merged

Merge pull request #113 from radarhere/type-hints-replace-io.BytesIO

4051302

radarhere reviewed Feb 10, 2024

View reviewed changes

docs/reference/internal_modules.rst Outdated Show resolved Hide resolved

Update docs/reference/internal_modules.rst

3977124

Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>

radarhere approved these changes Feb 11, 2024

View reviewed changes

radarhere reviewed Feb 11, 2024

View reviewed changes

Merge branch 'main' into type-hints-replace-io.BytesIO

29dd025

radarhere force-pushed the type-hints-replace-io.BytesIO branch from beb6b8b to 29dd025 Compare February 11, 2024 11:03

radarhere merged commit 3374e91 into python-pillow:main Feb 13, 2024
57 checks passed

hugovk deleted the type-hints-replace-io.BytesIO branch February 13, 2024 10:49

radarhere mentioned this pull request Feb 13, 2024

Use IO[bytes] in type hints #7795

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `io.BytesIO` in type hints #7750

Replace `io.BytesIO` in type hints #7750

hugovk commented Jan 23, 2024

AlexWaygood Jan 23, 2024

AlexWaygood left a comment

nulano Jan 25, 2024

AlexWaygood Jan 25, 2024 •

edited

Loading

hugovk Jan 26, 2024

AlexWaygood Jan 26, 2024

AlexWaygood Jan 26, 2024

radarhere Jan 27, 2024

hugovk Jan 27, 2024

Viicos Feb 6, 2024 •

edited

Loading

radarhere Feb 6, 2024

Viicos Feb 7, 2024

AlexWaygood commented Jan 27, 2024

hugovk commented Jan 27, 2024

AlexWaygood Feb 7, 2024 •

edited

Loading

radarhere Feb 7, 2024

AlexWaygood Feb 7, 2024

radarhere Feb 7, 2024

radarhere Feb 8, 2024

AlexWaygood Feb 8, 2024

radarhere Feb 10, 2024

AlexWaygood Feb 10, 2024

radarhere Feb 11, 2024

nulano Feb 11, 2024

radarhere commented Feb 13, 2024



		def is_path(f: Any) -> TypeGuard[bytes \| str \| Path]:
		def is_path(f: Any) -> TypeGuard[StrOrBytesPath]:

	if is_path(font):
	if isinstance(font, Path):
	font = str(font)
	if sys.platform == "win32":
	font_bytes_path = font if isinstance(font, bytes) else font.encode()



		FileDescriptor = int
		StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]

	StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]
	StrOrBytesPath = Union[str, bytes, os.PathLike[str], os.PathLike[bytes]]

		@@ -29,4 +32,4 @@ def read(self, __length: int = ...) -> _T_co:
		StrOrBytesPath = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]


		__all__ = ["FileDescriptor", "TypeGuard", "StrOrBytesPath", "SupportsRead"]

	__all__ = ["TypeGuard"]
	__all__ = ["FileDescriptor", "TypeGuard", "StrOrBytesPath", "SupportsRead"]

	if is_path(fp):
	# filename
	self.fp = open(fp, "rb")
	self.filename = fp
	self._exclusive_fp = True
	else:
	# stream
	self.fp = fp
	self.filename = filename
	# can be overridden
	self._exclusive_fp = None

Replace io.BytesIO in type hints #7750

Replace io.BytesIO in type hints #7750

Conversation

hugovk commented Jan 23, 2024

Choose a reason for hiding this comment

AlexWaygood left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexWaygood Jan 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Viicos Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexWaygood commented Jan 27, 2024

hugovk commented Jan 27, 2024

AlexWaygood Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radarhere commented Feb 13, 2024

Replace `io.BytesIO` in type hints #7750

Replace `io.BytesIO` in type hints #7750

AlexWaygood Jan 25, 2024 •

edited

Loading

Viicos Feb 6, 2024 •

edited

Loading

AlexWaygood Feb 7, 2024 •

edited

Loading