Fixed combining single duration across duplicate APNG frames#7146
Merged
mergify[bot] merged 3 commits intopython-pillow:mainfrom Jun 6, 2023
Merged
Fixed combining single duration across duplicate APNG frames#7146mergify[bot] merged 3 commits intopython-pillow:mainfrom
mergify[bot] merged 3 commits intopython-pillow:mainfrom
Conversation
|
I've been using a local build with this patch for a few weeks now and it's been working well, hopefully we can get this merged soon :) |
Member
Author
|
Be aware that even if it is merged, Pillow 10.0.0 is not due out until July 1. |
|
Yup, just looking forward to being able to remove the applying of these patches from my CI infrastructure and providing patching instructions to anyone who wants to run my code. I'm fine using |
hugovk
reviewed
Jun 6, 2023
hugovk
approved these changes
Jun 6, 2023
Member
Author
|
Pillow 10.0.0 has now been released with this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7144
When saving APNG files, we are testing that when duplicate frames are combined, the different durations are added together.
Pillow/Tests/test_file_apng.py
Lines 433 to 441 in 2a274a4
However, we aren't testing that the durations are combined when the
durationkeyword is a single number, rather than a list or a tuple. This issue found that this situation fails, and this PR corrects that.