Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DDS support for uncompressed L and LA images #6820

Merged
merged 4 commits into from
Dec 26, 2022
Merged

Added DDS support for uncompressed L and LA images #6820

merged 4 commits into from
Dec 26, 2022

Conversation

radarhere
Copy link
Member

#6486 refactors the DDS plugin, but also adds support for reading and writing uncompressed L and LA images.

This PR extracts that new functionality, without the refactoring.

In https://learn.microsoft.com/en-us/windows/win32/direct3ddds/dds-pixelformat, DDPF_LUMINANCE is described as

Used in some older DDS files for single channel color uncompressed data

It

Can be combined with DDPF_ALPHAPIXELS for a two channel DDS file.

hugovk
hugovk approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's also add to release notes.

@radarhere
Copy link
Member Author

Ok, I've added a commit for that.

@hugovk hugovk merged commit 0a19b34 into python-pillow:main Dec 26, 2022
@radarhere radarhere deleted the dds_l branch December 26, 2022 08:17
@radarhere radarhere mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radarhere @hugovk @REDxEYE