-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenSSF Best Practices badge #6597
Add OpenSSF Best Practices badge #6597
Conversation
README.md
Outdated
@@ -74,6 +74,9 @@ As of 2019, Pillow development is | |||
<a href="https://pypi.org/project/Pillow/"><img | |||
alt="Number of PyPI downloads" | |||
src="https://img.shields.io/pypi/dm/pillow.svg"></a> | |||
<a href="https://bestpractices.coreinfrastructure.org/projects/6331"><img | |||
alt="CII Best Practices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alt="CII Best Practices" | |
alt="openssf best practices" |
I think the alt text should reflect what is otherwise seen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, looks like they've not updated the template at https://bestpractices.coreinfrastructure.org/en/projects/6331 since they renamed:
This project was formerly known as the Core Infrastructure Initiative (CII) Best Practices badge. and was originally developed under the CII. It is now part of the OpenSSF Best Practices Working Group (WG). The OpenSSF is a foundation of the Linux Foundation (LF). The project was formally renamed from "CII Best Practices badge" on 2021-12-24.
I'll send them feedback, and also update the alts to use proper caps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent them a PR: coreinfrastructure/best-practices-badge#1863
docs/index.rst
Outdated
@@ -69,6 +69,10 @@ Pillow for enterprise is available via the Tidelift Subscription. `Learn more <h | |||
:target: https://pypi.org/project/Pillow/ | |||
:alt: Number of PyPI downloads | |||
|
|||
.. image:: https://bestpractices.coreinfrastructure.org/projects/6331/badge | |||
:target: https://bestpractices.coreinfrastructure.org/projects/6331 | |||
:alt: CII Best Practices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:alt: CII Best Practices | |
:alt: openssf best practices |
602343a
to
1bdf6ef
Compare
I started filling out the sections at https://bestpractices.coreinfrastructure.org/en/projects/6331 and we're currently at 76%:
Still some more to check, but we can already add the badge:
Preview
README
https://github.com/hugovk/Pillow/tree/add-openssf-best-practices-badge
Docs
https://pillow--6597.org.readthedocs.build/en/6597/