Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snprintf instead of sprintf #5567

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Conversation

radarhere
Copy link
Member

Resolves

/* FIXME: may overflow if mode is too large */

and
/* FIXME: may overflow if mode is too large */

Copy link
Member

@wiredfool wiredfool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to truncate the mode prior to passing to sprintf

@radarhere radarhere requested a review from wiredfool June 30, 2021 13:54
@radarhere radarhere merged commit 31c4738 into python-pillow:master Jul 1, 2021
@radarhere radarhere deleted the sprintf branch July 1, 2021 02:58
@radarhere radarhere changed the title Limit sprintf modes to 10 characters Use snprintf instead of sprintf Jul 1, 2021
radarhere added a commit to radarhere/Pillow that referenced this pull request Jul 1, 2021
@radarhere
Copy link
Member Author

This is fix for CVE-2021-34552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants