Fix #256 : check the file existence instead of check if path exists before load a timezone related file #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the file existence instead of check path exists (which can be valid for folders too).
|
Hi @beci - thanks for taking the time to figure out what was causing problems with loading the zonefiles in some situations. This looks like a good way to fix them! Thanks for the contribution. |
This was referenced Jan 25, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
It's very frustrating, that a single folder existence can take down the whole module. It seems there are linux package maintainers, who think creating a
/etc/timezonefolder is a good idea. This fixes #256 , I'm quite surprised this has open since 2018 and the bug still exists in 2022.This fix handles this by checking the file existence instead of path existence before reading timezone-related files.
Instead creating a simple
timezonefolder inpendulum/tests/fixtures/tz/symlink/etc/a created a complete fixture for this problem inpendulum/tests/fixtures/tz/timezone_dir/and a test with that folder.