Skip to content

Move Unmarshallers to separate subpackage #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Jan 23, 2020

Next step in package cleanup/refactoring

@p1c2u p1c2u added the WIP Work in progress label Jan 23, 2020
@p1c2u p1c2u force-pushed the refactor/move-unmarshallers-to-subpackage branch from d6099fe to f0329bb Compare January 23, 2020 16:48
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #183 into master will decrease coverage by 0.14%.
The diff coverage is 92.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   96.46%   96.32%   -0.15%     
==========================================
  Files          78       84       +6     
  Lines        1756     1794      +38     
==========================================
+ Hits         1694     1728      +34     
- Misses         62       66       +4
Impacted Files Coverage Δ
openapi_core/validation/request/datatypes.py 100% <ø> (ø) ⬆️
openapi_core/schema/schemas/exceptions.py 91.66% <ø> (+4.39%) ⬆️
openapi_core/schema/media_types/models.py 90.47% <100%> (+0.23%) ⬆️
openapi_core/schema/schemas/types.py 100% <100%> (ø) ⬆️
openapi_core/schema/schemas/models.py 97.97% <100%> (+2.71%) ⬆️
openapi_core/schema/extensions/generators.py 100% <100%> (ø)
openapi_core/schema/exceptions.py 100% <100%> (ø) ⬆️
openapi_core/exceptions.py 100% <100%> (ø)
openapi_core/schema/parameters/models.py 97.18% <100%> (-0.04%) ⬇️
openapi_core/unmarshalling/schemas/factories.py 100% <100%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745736b...b026fb2. Read the comment docs.

@p1c2u p1c2u marked this pull request as ready for review January 23, 2020 16:53
@p1c2u p1c2u force-pushed the refactor/move-unmarshallers-to-subpackage branch from f0329bb to 7570b8e Compare January 23, 2020 17:01
@p1c2u p1c2u removed the WIP Work in progress label Jan 23, 2020
@p1c2u p1c2u force-pushed the refactor/move-unmarshallers-to-subpackage branch 6 times, most recently from 69d1e21 to 84791e9 Compare January 23, 2020 18:19
@p1c2u p1c2u force-pushed the refactor/move-unmarshallers-to-subpackage branch from 84791e9 to b026fb2 Compare January 23, 2020 18:30
@p1c2u p1c2u merged commit ca63475 into master Jan 23, 2020
@p1c2u p1c2u deleted the refactor/move-unmarshallers-to-subpackage branch January 23, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant