Skip to content

OpenAPI request/response factories introduction #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 19, 2019

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Oct 19, 2019

Get rid of wrappers. Use OpenAPI request and response factories.

Backward incompatibility:

  • validate_body, validate_parameters and validate_data no longer accept wrapper_class, request_wrapper_class and response_wrapper_class keyword arguments. Use request_factory and response_factory instead.
  • openapi_core.wrappers.flask module moved to openapi_core.contrib.flask
  • openapi_core.wrappers.mock module moved to openapi_core.testing.mock

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #166 into master will decrease coverage by 0.04%.
The diff coverage is 98.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   96.57%   96.53%   -0.05%     
==========================================
  Files          62       64       +2     
  Lines        1692     1672      -20     
==========================================
- Hits         1634     1614      -20     
  Misses         58       58
Impacted Files Coverage Δ
openapi_core/contrib/flask/__init__.py 100% <100%> (ø)
openapi_core/validation/request/datatypes.py 100% <100%> (ø) ⬆️
openapi_core/shortcuts.py 100% <100%> (ø) ⬆️
openapi_core/validation/response/datatypes.py 100% <100%> (ø) ⬆️
openapi_core/testing/mock.py 100% <100%> (ø)
openapi_core/contrib/flask/responses.py 100% <100%> (ø)
openapi_core/testing/__init__.py 100% <100%> (ø)
openapi_core/validation/request/validators.py 94.59% <100%> (+0.07%) ⬆️
openapi_core/contrib/flask/requests.py 92.3% <92.3%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0604145...76d5081. Read the comment docs.

@p1c2u p1c2u changed the title Request/response factories introduction OpenAPI request/response factories introduction Oct 19, 2019
@p1c2u p1c2u merged commit 9be404e into master Oct 19, 2019
@p1c2u p1c2u deleted the feature/wrappers-restructure branch October 19, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant