Modify FlaskOpenAPIRequest to accomodate path variables #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds flask_wrapper.yaml spec
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 95.83% 95.91% +0.07%
==========================================
Files 56 56
Lines 1538 1541 +3
==========================================
+ Hits 1474 1478 +4
+ Misses 64 63 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 95.83% 95.91% +0.07%
==========================================
Files 56 56
Lines 1538 1541 +3
==========================================
+ Hits 1474 1478 +4
+ Misses 64 63 -1
Continue to review full report at Codecov.
|
|
@bjmc thank you for the contribution. LGTM |
p1c2u
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is a partial fix for #35 (see also #93). It doesn't attempt to solve the general case of accommodating all the possible routers out there. Instead, this is a limited set of changes confined to the
wrappers.flaskmodule that uses a regex to transform the Flask URL variables into OpenAPI path parameters.Thanks for your work on this very useful library.