1)whitelist becomes ignore

2)element to be ignored now can be css selector or needle web element
3)querySelector is not used anymore in order to find the element

Author: Andrea Bisello

needle/cases.py

@@ -124,19 +124,19 @@ def set_viewport_size(cls, width, height):
 
         cls.driver.set_window_size(width + delta, height)
 
-    def assertScreenshot(self, element_or_selector, file, whitelist=[], threshold=0):
+    def assertScreenshot(self, element_or_selector, file, ignore=[], threshold=0):
         """assert-style variant of compareScreenshot context manager
 
         compareScreenshot() can be considerably more efficient for recording baselines by avoiding the need
         to load pages before checking whether we're actually going to save them. This function allows you
         to continue using normal unittest-style assertions if you don't need the efficiency benefits
         """
 
-        with self.compareScreenshot(element_or_selector, file, whitelist=whitelist, threshold=threshold):
+        with self.compareScreenshot(element_or_selector, file, ignore=ignore, threshold=threshold):
             pass
 
     @contextmanager
-    def compareScreenshot(self, element_or_selector, file, whitelist = [], threshold=0):
+    def compareScreenshot(self, element_or_selector, file, ignore = [], threshold=0):
         """
         Assert that a screenshot of an element is the same as a screenshot on disk,
         within a given threshold.
@@ -149,18 +149,25 @@ def compareScreenshot(self, element_or_selector, file, whitelist = [], threshold
             If a string, then assumed to be the filename for the screenshot,
             which will be appended with ``.png``. Otherwise assumed to be
             a file object for the baseline image.
-        :param whitelist:
-            element found by this array of css selector will be set to visibility hidden in order avoid making test fails
+        :param ignore:
+            Either a CSS selector as a string or a
+            :py:class:`~needle.driver.NeedleWebElement` object that represents
+            the element to be ignored in the screenshot comparison (element will disappear from image).
         :param threshold:
             The threshold for triggering a test failure.
         """
 
         yield  # To allow using this method as a context manager
 
-        if len(whitelist) > 0:
-            for whiteListThis in whitelist:
-                script = "document.querySelector('"+whiteListThis+"').style.visibility = 'hidden'"
-                self.driver.execute_script(script)
+        # Hiding element to be ignored in screenshot comparisons
+        if len(ignore) > 0:
+            for element_to_be_ignored in ignore:
+                if not isinstance(element_to_be_ignored, NeedleWebElement):
+                    element = self.driver.find_element_by_css_selector(element_to_be_ignored)
+                else:
+                    element = element_to_be_ignored
+                self.driver.execute_script('arguments[0].style.visibility="hidden";', element)
+
 
         if not isinstance(element_or_selector, NeedleWebElement):
             element = self.driver.find_element_by_css_selector(element_or_selector)