Skip to content

Add black and updated docs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2020
Merged

Conversation

felipem775
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 11, 2020

Coverage Status

Coverage remained the same at 86.538% when pulling c481c0a on felipem775:master into 8ea55dd on python-microservices:master.

@felipem775 felipem775 marked this pull request as draft October 11, 2020 22:17
@felipem775 felipem775 changed the title fix: Replace parameter for pip. -e should be -r doc: Replace parameter for pip. -e should be -r Oct 11, 2020
@felipem775 felipem775 changed the title doc: Replace parameter for pip. -e should be -r Add black and updated docs Oct 11, 2020
@avara1986 avara1986 linked an issue Oct 12, 2020 that may be closed by this pull request
@avara1986 avara1986 marked this pull request as ready for review October 15, 2020 18:04
@alexppg
Copy link
Member

alexppg commented Oct 15, 2020

What do you thing about adding pytest-black to the CI to make sure everybody uses it? https://pypi.org/project/pytest-black/ @avara1986 @felipem775

@avara1986
Copy link
Member

Good idea @alexppg! but we could add this package in these steps:

  • Add black with pre-commit
  • Update all repository with black's changes
  • Add pytest-black to prevent new "errors" of format

What do you say? :) do we create a issue to add this validation? 💪

@alexppg
Copy link
Member

alexppg commented Oct 15, 2020

Nice, done then. #218 and #219

@alexppg alexppg merged commit eee9732 into python-microservices:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Black
4 participants