Make cache_config option False per review

Author: ccordoba12

pylsp_black/plugin.py

@@ -196,7 +196,7 @@ def load_config(filename: str, client_config: Config) -> Dict:
     settings = client_config.plugin_settings("black")
 
     # Use the original, not cached function to load settings if requested
-    if not settings.get("cache_config", True):
+    if not settings.get("cache_config", False):
         return _load_config.__wrapped__(filename, client_config)
 
     return _load_config(filename, client_config)

tests/test_plugin.py

@@ -36,7 +36,7 @@ def config(workspace):
     """Return a config object."""
     cfg = Config(workspace.root_uri, {}, 0, {})
     cfg._plugin_settings = {
-        "plugins": {"black": {"line_length": 88, "cache_config": True}}
+        "plugins": {"black": {"line_length": 88, "cache_config": False}}
     }
     return cfg
 
@@ -313,16 +313,15 @@ def test_pylsp_format_line_length(
 
 
 def test_cache_config(config, unformatted_document):
-    # Cache should be working by default
+    # Cache should be off by default
     for _ in range(5):
         pylsp_format_document(config, unformatted_document)
-    assert _load_config.cache_info().hits == 4
+    assert _load_config.cache_info().hits == 0
 
-    # Clear cache and disable it
-    _load_config.cache_clear()
-    config.update({"plugins": {"black": {"cache_config": False}}})
+    # Enable cache
+    config.update({"plugins": {"black": {"cache_config": True}}})
 
-    # Cache should not be working now
+    # Cache should be working now
     for _ in range(5):
         pylsp_format_document(config, unformatted_document)
-    assert _load_config.cache_info().hits == 0
+    assert _load_config.cache_info().hits == 4