Bind collector: Adding support for new some v3 XML bind9 stats and JSON v1 #562
Conversation
| @@ -35,6 +35,10 @@ def get_default_config_help(self): | |||
| " - memory (Global memory usage)\n", | |||
| 'publish_view_bind': "", | |||
| 'publish_view_meta': "", | |||
| 'data_format': "Bind stats version:\n" + | |||
| " - xml_v2 (Original bind stats version from 9.5)\n" + | |||
There was a problem hiding this comment.
You should pick xml or xml_v2 and make sure its consistent throughout
There was a problem hiding this comment.
Looks like this was corrected, thanks!
|
Tests and doc need to be updated as well |
|
pep8 errors need to be addressed as well |
|
Ooops. Still need to do tests and docs. |
|
I don't have a python 2.6 environment to test this in. What's your stance on this feature not working in python 2.6? |
|
2.6 is still supported by the project technically, but i will let others speak to that point |
| @@ -32,6 +32,12 @@ publish | resolver, server, zonemgmt, sockets, memory, | Available stats:<br> | |||
| | list | |||
There was a problem hiding this comment.
mode change?
100644 → 100755
| @@ -32,6 +32,12 @@ publish | resolver, server, zonemgmt, sockets, memory, | Available stats:<br> | |||
| | list | |||
| publish_view_bind | False | | bool | |||
| publish_view_meta | False | | bool | |||
| data_format | xml_v2 | Bind stats version:<br> | |||
There was a problem hiding this comment.
The table gets messed up, not sure whats the best way to handle it though
| @@ -63,17 +69,75 @@ def get_default_config(self): | |||
| # By default we don't publish these special views | |||
| 'publish_view_bind': False, | |||
| 'publish_view_meta': False, | |||
| 'data_format': 'xml_v2', | |||
| 'derivative': True, | |||
There was a problem hiding this comment.
you have derivative in a separate PR
for xml_v3 and json_v1
Bind 9.11 has removed the old XML (v2) interface. This adds some support for key statistics under /server section of new v3 XML and v1 JSON interface.
Querying the root of the XML interface can cause bind to stop answering queries for several hundred milliseconds. Querying /server XML only 4-5ms, and /server for JSON 1-2ms.