Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add release process notes #550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josegonzalez
Copy link
Member

@jaingaurav Thoughts? I figure adding them here seems reasonable (I'd also like to get us on that regular release cadence).


- kormoc
- mattrobenolt
- savant
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include me here. I believe I have acce to upload releases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

git push origin --tags
```

From this point forward, the makefile will generate a version starting with 4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some guidelines for versioning. How about x.x.x:
Major - Major features, possible backwards incompatible changes, etc.
Minor - New collectors/handlers
Patch - Minor bug fixes, collector tweaks

What do you think? Would the minor number bump up too often with this scheme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems reasonable to me. Will modify the pull request.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we start splitting up collectors into individual repos, how would that change these versions numbers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd do a major release at that point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. If we split up all collectors/handlers into their own repos, what is a minor point release of the core at that point? Or do we bring them all together to package them so it's purely just a code artifact that they're split up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how a splitup works, but in theory if we add new - non-breaking - functionality to the core, thats a minor release?

@josegonzalez
Copy link
Member Author

One thing I'm not sure on how to do this, but how should we generate docs locally? Running make docs breaks without a conf/diamond.conf in the path, and if it's not installed. That seems... wrong?

@jaingaurav
Copy link
Member

So the docs are managed by readthedocs right?

But yeah I agree that running make should just work. I think we shouldn't rely on any config file for the building of anything.

@josegonzalez
Copy link
Member Author

Right but we generate md files for each collector, which I think is done via make docs.

@shortdudey123 Any thoughts here? I've noticed you commenting on issues in the past :)

@shortdudey123
Copy link
Member

When i generate docs, i do it inside the vagrant box that got merged in #467

@shortdudey123
Copy link
Member

With this PR in general though, it looks like it describes the problem of commits since the last tag, but does not appear to solve that problem

@josegonzalez
Copy link
Member Author

@shortdudey123 what would you change? My goal is to get us onto a two-week release cadence, with packaging available for all stable LTS distros.

@shortdudey123
Copy link
Member

If the intention is to switch to semver, then i would say that needs to be explicitly called out. Looks like @jaingaurav added a comment about it already :)

@shortdudey123
Copy link
Member

@jaingaurav @josegonzalez further thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants