Skip to content

Ctrl-C now stops a running text script instead of just the current script command #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2020

Conversation

kmvanbrunt
Copy link
Member

Fixes #909

tleonhardt
tleonhardt previously approved these changes Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #910 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   97.48%   97.56%   +0.08%     
==========================================
  Files          15       15              
  Lines        3691     3699       +8     
==========================================
+ Hits         3598     3609      +11     
+ Misses         93       90       -3     
Impacted Files Coverage Δ
cmd2/cmd2.py 96.90% <100.00%> (+0.22%) ⬆️
cmd2/utils.py 97.92% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990ec45...38b37a9. Read the comment docs.

… make their way up to our code.

This is more consistent than raising the rare few that we see.
@kmvanbrunt kmvanbrunt merged commit 274a57b into master Mar 26, 2020
@kmvanbrunt kmvanbrunt deleted the ctrl-c-script branch March 26, 2020 19:25
@JimRowan
Copy link

nice, thank for the super-quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command scripts cannot be interrupted
3 participants