Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we run DB tests also in local env? #149

Open
Borda opened this issue Feb 2, 2024 · 3 comments
Open

Can we run DB tests also in local env? #149

Borda opened this issue Feb 2, 2024 · 3 comments

Comments

@Borda
Copy link
Contributor

Borda commented Feb 2, 2024

So far, the major bottleneck for any contributor and eventually maintainers are the DB tests

  • contributor: does not get them rum as they connect to some external DB, and GH does not share credentials to fork PRs
  • maintainer: he needs to pul the PR to a branch and run all tests before it lands on main/dev branch

So my question, and feel free to discuss it in another form (DM) what is so special with this DB, and can we just start one locally within the job and run tests against it?

Seems there are some actions offering running MongoDB locally: https://github.com/marketplace/actions/mongodb-in-github-actions

@shaypal5
Copy link
Collaborator

shaypal5 commented Feb 2, 2024

Nothing special about it.

Having pytest set up a local MongoDB and a connection to it as a fixture for the MongoDB test suite is a great idea, and something I wanted to do for a while, but haven't gotten around to.

I fully support a PR converting all such tests to run against a local server!

@Borda
Copy link
Contributor Author

Borda commented Feb 2, 2024

just for the record, after this is addressed we can also proceed with #146

@shaypal5
Copy link
Collaborator

shaypal5 commented Feb 2, 2024

just for the record, after this is addressed we can also proceed with #146

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants