Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark wraptext deprecated; use TextWrapper directly in write_po #1140

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

akx
Copy link
Member

@akx akx commented Oct 19, 2024

Related to #1120.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (d4069ee) to head (194a52f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
- Coverage   91.28%   91.27%   -0.01%     
==========================================
  Files          27       27              
  Lines        4602     4621      +19     
==========================================
+ Hits         4201     4218      +17     
- Misses        401      403       +2     
Flag Coverage Δ
macos-12-3.10 90.04% <100.00%> (-0.05%) ⬇️
macos-12-3.11 89.98% <100.00%> (-0.05%) ⬇️
macos-12-3.12 90.19% <100.00%> (-0.01%) ⬇️
macos-12-3.13-dev 89.72% <100.00%> (-0.01%) ⬇️
macos-12-3.8 89.97% <100.00%> (-0.05%) ⬇️
macos-12-3.9 89.97% <100.00%> (-0.05%) ⬇️
macos-12-pypy3.10 90.04% <100.00%> (-0.05%) ⬇️
ubuntu-22.04-3.10 90.06% <100.00%> (-0.05%) ⬇️
ubuntu-22.04-3.11 90.00% <100.00%> (-0.05%) ⬇️
ubuntu-22.04-3.12 90.21% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-3.13-dev 89.74% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-3.8 89.99% <100.00%> (-0.05%) ⬇️
ubuntu-22.04-3.9 89.99% <100.00%> (-0.05%) ⬇️
ubuntu-22.04-pypy3.10 90.06% <100.00%> (-0.05%) ⬇️
windows-2022-3.10 90.18% <100.00%> (-0.05%) ⬇️
windows-2022-3.11 90.12% <100.00%> (-0.05%) ⬇️
windows-2022-3.12 90.33% <100.00%> (-0.01%) ⬇️
windows-2022-3.13-dev 89.86% <100.00%> (-0.01%) ⬇️
windows-2022-3.8 90.11% <100.00%> (-0.05%) ⬇️
windows-2022-3.9 90.11% <100.00%> (-0.05%) ⬇️
windows-2022-pypy3.10 90.18% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits, otherwise LGTM!

babel/util.py Outdated Show resolved Hide resolved
babel/util.py Outdated Show resolved Hide resolved
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@akx akx requested a review from tomasr8 October 20, 2024 06:49
@akx
Copy link
Member Author

akx commented Oct 20, 2024

@tomasr8 Good comments, thanks! 😄

@akx akx enabled auto-merge (squash) October 20, 2024 06:49
@akx akx merged commit 8e12f54 into master Oct 20, 2024
26 checks passed
@akx akx deleted the faster-po-write branch October 21, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants