Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check_and_call_extract_file uses the first matching method and options, instead of the first matching method and last matching options #1121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpmckinney
Copy link

@jpmckinney jpmckinney commented Aug 21, 2024

Otherwise, if I want to use a different method for one file AND use options, I can't do, for example:

[myextractor: path/file.py]
myoption = myvalue

[python: path/**.py]

The current code will match path/file.py to myextractor, but it'll use the empty options from python...

…ptions, instead of the first matching method and last matching options
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you add a test for this? Thanks!

@jpmckinney
Copy link
Author

I would love to, but it's very hard to figure out where/how to test this. Basically, I'd need some scaffolding to be able to provide a configuration file, source files and a custom extractor and test whether the output is as expected.

@akx akx self-assigned this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants