Skip to content

Remove async activation magic in notebook_integration.py #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Mar 3, 2025

This has been the default for years and seems to no longer work.

See failing docs build here https://app.readthedocs.org/projects/pipefunc/builds/27380513/.

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

This has been the default for years and seems to no longer work
@basnijholt basnijholt merged commit 2820e1f into main Mar 3, 2025
15 of 17 checks passed
@basnijholt basnijholt deleted the basnijholt-patch-1 branch March 3, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant