Skip to content

Update Python version requirement to 3.9 in accordance with NEP 29 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2023

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Apr 29, 2023

This PR updates the minimum required Python version to 3.9, following the recommendations of NEP 29. NEP 29 provides a formalized deprecation policy for supported Python versions in the scientific Python ecosystem, which can help us maintain compatibility and reduce maintenance overhead.

The proposed changes include:

  • Updating the minimum Python version requirement in pyproject.toml
  • Updating the CI/CD pipelines to test against Python 3.9
  • Updating the documentation to reflect the new requirement

Before proceeding with these changes, we'd like to gather input from the community (@jbweston and @akhmerov):

  1. Is there any reason to delay this update or maintain support for older Python versions?
  2. Are there any potential conflicts or compatibility issues that could arise from updating the minimum Python version?

Please provide your feedback and let us know if you have any concerns or suggestions related to this update.

Otherwise, I have also opened #417

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt changed the title Bump minimal Python to ≥3.9 Update Python version requirement to 3.9 in accordance with NEP 29 Apr 29, 2023
@basnijholt basnijholt requested review from jbweston and akhmerov April 29, 2023 08:34
@basnijholt basnijholt marked this pull request as ready for review April 29, 2023 08:35
@basnijholt basnijholt merged commit 6014918 into main Apr 30, 2023
@basnijholt basnijholt deleted the drop-py38 branch April 30, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants