Skip to content

Add type-hints to BalancingLearner #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

basnijholt
Copy link
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt changed the title Add type-hints to adaptive/learner/balancing_learner.py Add type-hints to BalancingLearner Oct 12, 2022
@basnijholt basnijholt enabled auto-merge (squash) October 12, 2022 04:35
@basnijholt basnijholt force-pushed the type-hint-balancing-learner branch from 87961cd to afc2b5f Compare October 12, 2022 04:40
@codecov-commenter
Copy link

Codecov Report

Merging #371 (afc2b5f) into main (1b7e84d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   77.67%   77.65%   -0.03%     
==========================================
  Files          37       37              
  Lines        5393     5401       +8     
  Branches      981      981              
==========================================
+ Hits         4189     4194       +5     
- Misses       1058     1059       +1     
- Partials      146      148       +2     
Impacted Files Coverage Δ
adaptive/learner/balancing_learner.py 71.74% <100.00%> (+1.05%) ⬆️
adaptive/learner/average_learner1D.py 73.66% <0.00%> (-1.00%) ⬇️
adaptive/learner/learner1D.py 86.91% <0.00%> (-0.75%) ⬇️
adaptive/learner/learnerND.py 59.10% <0.00%> (+0.37%) ⬆️
adaptive/tests/test_cquad.py 92.25% <0.00%> (+0.64%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt basnijholt merged commit 6127d72 into main Oct 12, 2022
@basnijholt basnijholt deleted the type-hint-balancing-learner branch October 12, 2022 06:30
@basnijholt basnijholt mentioned this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants