This repository was archived by the owner on May 6, 2025. It is now read-only.
Update the SDK for downstream optimizations #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful for testing in solidity (using Foundry)
This will allow downstream further optimizations
Events changes are breaking only to downstream consumers and not for on-chain consumers. So it's minor for on-chain usage.
ali-behjati
requested review from
jayantk,
tompntn and
njk-64
and removed request for
jayantk
tompntn
approved these changes
Nov 14, 2022
njk-64
approved these changes
Nov 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the SDK for optimization purposes that:
AbstractPythmethods virtual to allow the downstream contracts to override the methods for optimization.It also moves the events to
IPythEventsinterface so they can be used in solidity tests.