[accumulator-updater 6/x] Funding account #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jayantk
approved these changes
Apr 19, 2023
| cpi_caller.as_ref(), | ||
| ACCUMULATOR.as_ref(), | ||
| base_account_key.as_ref(), | ||
| &[bump], | ||
| ]; | ||
| let fund_pda_bump = *ctx | ||
| .bumps | ||
| .get("fund") |
There was a problem hiding this comment.
sorry missed these, will update in #772
| @@ -45,8 +45,10 @@ pub struct UpdatePrice<'info> { | |||
| bump, | |||
| )] | |||
| pub pyth_price_account: AccountLoader<'info, PriceAccount>, | |||
| // #[account(mut)] | |||
| // pub payer: Signer<'info>, | |||
There was a problem hiding this comment.
sorry missed these, will update in #772
| @@ -15,6 +15,10 @@ const accumulatorUpdaterProgram = anchor.workspace | |||
| .AccumulatorUpdater as Program<AccumulatorUpdater>; | |||
| const mockCpiProg = anchor.workspace.MockCpiCaller as Program<MockCpiCaller>; | |||
| let whitelistAuthority = anchor.web3.Keypair.generate(); | |||
| const [fundPda] = anchor.web3.PublicKey.findProgramAddressSync( | |||
| [Buffer.from("accumulator"), Buffer.from("fund")], | |||
There was a problem hiding this comment.
can you write down the system for seed paths somewhere? It's a little confusing to me that the "fund" seed is under "accumulator" -- i thought that "accumulator" was the path for the account keys.
There was a problem hiding this comment.
i didn't really have any system for these it was arbitrarily chosen. i'll change the fund's seeds to be just "fund"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
SystemAccountthat will be used as the payer for allAccumulatorInputaccount creationUpdates
fundaccount toput_allix and list of accounts passed frommock_cpi_callerTODOs
AccumulatorInput/AccumulatorHeadertoMessageBuffer&MessageHeader- see comment