Skip to content

feat(pulse): add provider exclusivity period #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented Jan 22, 2025

No description provided.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 7:11am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 7:11am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 7:11am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 7:11am
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 7:11am
insights ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 7:11am

@cctdaniel cctdaniel changed the base branch from main to pulse-provider January 22, 2025 07:08
@cctdaniel cctdaniel changed the title provider exclusivity period feat(pulse): add provider exclusivity period Jan 22, 2025
Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like going with default provider for now. You'd need to update some other functions like getFee.

I think it might be easier to review all in the previous PR so feel free to merge it and I'll review that one later.

@cctdaniel cctdaniel merged commit f67734f into pulse-provider Jan 23, 2025
11 checks passed
@cctdaniel cctdaniel deleted the provider-exclusivity-period branch January 23, 2025 05:24
cctdaniel added a commit that referenced this pull request Jan 24, 2025
* add provider

* remove unnecessary code

* fix test

* add exclusivity period to provider (#2282)

* make exclusivityPeriodSeconds configurable

* remove provider arg from getFee

* remove provider from callback args

* add comments

* add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants