chore(hermes): Remove git from build, vendor WH & Google protos #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tejasbadadare
requested review from
ali-behjati and
cprussin
and removed request for
ali-behjati
tejasbadadare
commented
Nov 5, 2024
Comment on lines
+13
to
+14
| To be honest, we probably open sourced way too much of this (basically by | ||
| accident). There are a couple files in here you are most likely to be |
ali-behjati
reviewed
Nov 6, 2024
apps/hermes/server/.gitignore
Outdated
| @@ -7,4 +7,6 @@ src/network/p2p.proto | |||
| tools/ | |||
|
|
|||
| # Ignore Wormhole cloned repo | |||
| # (Legacy -- we no longer clone the Wormhole repo, the proto files are included in this project under `proto/vendor`. | |||
There was a problem hiding this comment.
let's remove it entirely.
ali-behjati
approved these changes
Nov 6, 2024
ali-behjati
reviewed
Nov 6, 2024
ali-behjati
reviewed
Nov 6, 2024
.pre-commit-config.yaml
Outdated
| (?x)^( | ||
| target_chains/sui/vendor/| | ||
| patches/| | ||
| apps/hermes/server/proto/ |
There was a problem hiding this comment.
probably make it /proto/vendor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hermes
build.rscurrently pulls the wormhole and googleapis git repositories in order to get the WH protobuf definitions. (The WH protos depend on googleapi protos, so those are downloaded as well.)Aside from a slow build, this causes some issues with LSP. TLDR: The build doesn't clean up the .git lock which breaks incremental builds, since subsequent builds fail to
git init. On my machine, this manifests ascargo watchandrust-analyzernot working since they continuously and incrementally build.Talking to @ali-bahjati , we concluded that vendoring in the required protobufs is preferable to constantly downloading them from git, which is what this PR does.
Both repos are Apache 2.0 licensed (as are we) so we should be good to include them directly.
The build is much faster now :)
Notes:
service.proto. This works fine as the WH protos only depend on a select few google ones.