Skip to content

Commit f3ec2b5

Browse files
authored
fix: minor fixes (#2166)
* use getSignaturesForAddress * handle promise error
1 parent 00859ba commit f3ec2b5

File tree

2 files changed

+22
-17
lines changed

2 files changed

+22
-17
lines changed

governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -508,22 +508,6 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
508508
)
509509
}
510510

511-
// check if minPub has changed
512-
if (
513-
prev.priceAccounts[0].minPub !== newChanges.priceAccounts[0].minPub
514-
) {
515-
// create update product account instruction
516-
instructions.push(
517-
await pythProgramClient.methods
518-
.setMinPub(newChanges.priceAccounts[0].minPub, [0, 0, 0])
519-
.accounts({
520-
priceAccount: new PublicKey(prev.priceAccounts[0].address),
521-
fundingAccount,
522-
})
523-
.instruction()
524-
)
525-
}
526-
527511
// check if maxLatency has changed
528512
if (
529513
prev.priceAccounts[0].maxLatency !==
@@ -584,6 +568,22 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
584568
)
585569
await initPublisherInPriceStore(publisherPubKey)
586570
}
571+
572+
// check if minPub has changed
573+
if (
574+
prev.priceAccounts[0].minPub !== newChanges.priceAccounts[0].minPub
575+
) {
576+
// create update product account instruction
577+
instructions.push(
578+
await pythProgramClient.methods
579+
.setMinPub(newChanges.priceAccounts[0].minPub, [0, 0, 0])
580+
.accounts({
581+
priceAccount: new PublicKey(prev.priceAccounts[0].address),
582+
fundingAccount,
583+
})
584+
.instruction()
585+
)
586+
}
587587
}
588588
}
589589

governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/ProposalRow.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,19 @@ export const ProposalRow = ({
5656
// set proposal time
5757
if (!time) {
5858
connection
59-
.getConfirmedSignaturesForAddress2(proposal.publicKey)
59+
.getSignaturesForAddress(proposal.publicKey)
6060
.then((txs) => {
6161
if (isCancelled) return
6262
const firstBlockTime = txs?.[txs.length - 1]?.blockTime
6363
if (firstBlockTime) {
6464
setTime(new Date(firstBlockTime * 1000))
6565
}
6666
})
67+
.catch((err) => {
68+
console.error(
69+
`Error fetching proposal time for ${proposal.publicKey.toBase58()}: ${err}`
70+
)
71+
})
6772
}
6873

6974
// calculate instructions summary

0 commit comments

Comments
 (0)