chore: move all prettier formatting into individual packages

This PR makes a few related changes:

- Stops using `pre-commit` to run prettier anywhere in the monorepo, instead we
now run prettier from each package and trigger the runs using turborepo at the
root.

- Upgrade the prettier version used in all packages that were previously relying
on `pre-commit` to run prettier.

- Reformat files that need it due to the new prettier version.

- Cleans up the turborepo config so that it now runs some tasks in the root
package, and also automatically runs `pnpm install` when needed.

The main downside of this PR is that auto-formatting on pre-commit will no
longer happen, but for that I think we should help developers get their prettier
editor integration set up so it happens on file save.

Author: cprussin

.github/workflows/ci-turbo-test.yml

@@ -33,4 +33,4 @@ jobs:
       - name: Cache for Turbo
         uses: rharkor/caching-for-turbo@v1.5
       - name: Test
-        run: pnpm test:ci
+        run: pnpm turbo test

.pre-commit-config.yaml

@@ -23,16 +23,6 @@ repos:
             target_chains/sui/vendor/|
             patches/
           )
-  # Hook to format many type of files in the repo
-  # including solidity contracts.
-  - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: "v2.7.1"
-    hooks:
-      - id: prettier
-        additional_dependencies:
-          - "prettier@2.7.1"
-          - "prettier-plugin-solidity@1.0.0-rc.1"
-        exclude: target_chains/sui/vendor/
   - repo: local
     hooks:
       # Hooks for the remote executor

.prettierignore

@@ -1,25 +1,39 @@
 pnpm-lock.yaml
 patches/
 .turbo/
+target_chains/sui/vendor/
 
-# These apps have their own prettier config that uses a later version of
-# prettier
-#
-# TODO(cprussin): eventually I'll figure out how to upgrade prettier everywhere
-# and hook it in to pre-commit.  For now, I don't want to downgrade prettier in
-# the packages that are using the later version, and pre-commit doesn't support
-# later versions of prettier directly.
-#
-# Ideally, we should probably hook up a pre-commit script to run auto-fixes in a
-# generic way that packages can hook into by defining lifecycle scripts, or by
-# using the nx task graph.  Then, packages can use their own formatters /
-# formatter versions and can also hook up other auto-fixes like eslint, etc.
-#
-# I'll explore doing this when I get around to spending some time on our nx
-# build graph config.
-apps/api-reference
-apps/staking
-apps/insights
-apps/entropy-debugger
-governance/pyth_staking_sdk
+# This should stay in sync with the list of workspaces from
+# `pnpm-workspace.yaml`
+apps/*
 packages/*
+apps/hermes/client/js
+governance/xc_admin/packages/*
+governance/pyth_staking_sdk
+price_service/sdk/js
+price_service/client/js
+pythnet/message_buffer
+target_chains/aptos/cli
+target_chains/aptos/sdk/js
+target_chains/cosmwasm/tools
+target_chains/cosmwasm/deploy-scripts
+target_chains/ethereum/contracts
+target_chains/ethereum/abi_generator
+target_chains/ethereum/entropy_sdk/solidity
+target_chains/ethereum/sdk/js
+target_chains/ethereum/sdk/solidity
+target_chains/ethereum/sdk/stylus/pyth-mock-solidity
+target_chains/ethereum/examples/coin_flip/app
+target_chains/fuel/sdk/js
+target_chains/starknet/sdk/js
+target_chains/sui/sdk/js
+target_chains/sui/sdk/js-iota
+target_chains/sui/cli
+target_chains/sui/cli-iota
+target_chains/solana/sdk/js/solana_utils
+target_chains/solana/sdk/js/pyth_solana_receiver
+target_chains/ton/contracts
+target_chains/ton/sdk/js
+contract_manager
+lazer/contracts/solana
+lazer/sdk/js

apps/api-reference/turbo.json

@@ -3,27 +3,11 @@
   "extends": ["//"],
   "tasks": {
     "build": {
-      "dependsOn": ["pull:env", "^build"],
-      "outputs": [".next/**", "!.next/cache/**"],
       "env": [
         "WALLETCONNECT_PROJECT_ID",
         "AMPLITUDE_API_KEY",
         "GOOGLE_ANALYTICS_ID"
       ]
-    },
-    "pull:env": {
-      "outputs": [".env.local"],
-      "cache": false
-    },
-    "start:dev": {
-      "dependsOn": ["pull:env"],
-      "persistent": true,
-      "cache": false
-    },
-    "start:prod": {
-      "dependsOn": ["build"],
-      "persistent": true,
-      "cache": false
     }
   }
 }

apps/entropy-debugger/turbo.json

@@ -76,11 +76,12 @@ The [HermesClient](./src/examples/HermesClient.ts) example demonstrates both the
 examples above. To run the example:
 
 1. Clone [the Pyth monorepo](https://github.com/pyth-network/pyth-crosschain)
-2. In the root of the monorepo, run `pnpm example:hermes-client -- <args>`. For
-   example, to print BTC and ETH price feeds in the testnet network, run:
+2. In the root of the monorepo, run `pnpm turbo --filter
+   @pythnetwork/hermes-client example -- <args>`. For example, to print BTC and
+   ETH price feeds in the testnet network, run:
 
 ```bash
-pnpm example:hermes-client -- \
+pnpm turbo --filter @pythnetwork/hermes-client example -- \
   --endpoint https://hermes.pyth.network \
   --price-ids \
     0xe62df6c8b4a85fe1a67db44dc12de5db330f7ac66b72dc658afedf0f4a415b43 \

apps/hermes/client/js/README.md

@@ -3,22 +3,23 @@
   "extends": ["//"],
   "tasks": {
     "build:schemas": {
-      "dependsOn": ["pull:schema"],
+      "dependsOn": ["//#install:modules", "pull:schema"],
       "inputs": ["schema.json"],
       "outputs": ["src/zodSchemas.ts"]
     },
     "build:typescript": {
-      "dependsOn": ["build:schemas", "^build"],
+      "dependsOn": ["//#install:modules", "build:schemas", "^build"],
       "outputs": ["lib/**"]
     },
     "build": {
       "dependsOn": ["build:typescript", "build:schemas"]
     },
     "example": {
-      "dependsOn": ["build"],
+      "dependsOn": ["//#install:modules", "build"],
       "cache": false
     },
     "pull:schema": {
+      "dependsOn": ["//#install:modules"],
       "outputs": ["schema.json"],
       "cache": false
     }

apps/hermes/client/js/turbo.json

@@ -3,8 +3,6 @@
   "extends": ["//"],
   "tasks": {
     "build": {
-      "dependsOn": ["pull:env", "^build"],
-      "outputs": [".next/**", "!.next/cache/**"],
       "env": [
         "VERCEL_ENV",
         "GOOGLE_ANALYTICS_ID",
@@ -17,36 +15,28 @@
       ]
     },
     "fix:lint": {
-      "dependsOn": ["fix:lint:eslint", "fix:lint:stylelint"],
-      "cache": false
+      "dependsOn": [
+        "//#install:modules",
+        "fix:lint:eslint",
+        "fix:lint:stylelint"
+      ]
     },
     "fix:lint:eslint": {
-      "dependsOn": ["^build"],
+      "dependsOn": ["//#install:modules", "^build"],
       "cache": false
     },
     "fix:lint:stylelint": {
-      "cache": false
-    },
-    "pull:env": {
-      "outputs": [".env.local"],
-      "cache": false
-    },
-    "start:dev": {
-      "dependsOn": ["pull:env"],
-      "persistent": true,
-      "cache": false
-    },
-    "start:prod": {
-      "dependsOn": ["build"],
-      "persistent": true,
+      "dependsOn": ["//#install:modules"],
       "cache": false
     },
     "test:lint": {
       "dependsOn": ["test:lint:eslint", "test:lint:stylelint"]
     },
     "test:lint:eslint": {
-      "dependsOn": ["^build"]
+      "dependsOn": ["//#install:modules", "^build"]
     },
-    "test:lint:stylelint": {}
+    "test:lint:stylelint": {
+      "dependsOn": ["//#install:modules"]
+    }
   }
 }

apps/insights/turbo.json

@@ -3,8 +3,6 @@
   "extends": ["//"],
   "tasks": {
     "build": {
-      "dependsOn": ["pull:env", "^build"],
-      "outputs": [".next/**", "!.next/cache/**"],
       "env": [
         "IP_ALLOWLIST",
         "GOVERNANCE_ONLY_REGIONS",
@@ -17,23 +15,13 @@
         "GOOGLE_ANALYTICS_ID"
       ]
     },
-    "pull:env": {
-      "outputs": [".env.local"],
-      "cache": false
-    },
     "start:dev": {
       "dependsOn": [
+        "//#install:modules",
         "pull:env",
         "@pythnetwork/hermes-client#build",
         "@pythnetwork/solana-utils#build"
-      ],
-      "persistent": true,
-      "cache": false
-    },
-    "start:prod": {
-      "dependsOn": ["build"],
-      "persistent": true,
-      "cache": false
+      ]
     }
   }
 }

apps/staking/turbo.json

@@ -18,15 +18,15 @@
           cli = prev.lib.mkCli "cli" {
             _noAll = true;
 
-            start = "${prev.lib.getExe prev.pnpm} start:dev";
+            start = "${prev.lib.getExe prev.pnpm} turbo start:dev";
 
             test = {
               nix = {
                 lint = "${prev.statix}/bin/statix check --ignore node_modules .";
                 dead-code = "${prev.deadnix}/bin/deadnix --exclude ./node_modules .";
                 format = "${prev.alejandra}/bin/alejandra --exclude ./node_modules --check .";
               };
-              turbo = "${prev.lib.getExe prev.pnpm} test -- --ui stream";
+              turbo = "${prev.lib.getExe prev.pnpm} turbo test -- --ui stream";
             };
 
             fix = {
@@ -35,7 +35,7 @@
                 dead-code = "${prev.deadnix}/bin/deadnix --exclude ./node_modules -e .";
                 format = "${prev.alejandra}/bin/alejandra --exclude ./node_modules .";
               };
-              turbo = "${prev.lib.getExe prev.pnpm} fix -- --ui stream";
+              turbo = "${prev.lib.getExe prev.pnpm} turbo fix -- --ui stream";
             };
           };
         };

flake.nix

@@ -20,7 +20,7 @@ export const PROPOSAL_STATUSES = [
   'draft',
   'unkwown',
 ] as const
-export type ProposalStatus = typeof PROPOSAL_STATUSES[number]
+export type ProposalStatus = (typeof PROPOSAL_STATUSES)[number]
 
 export const getProposalStatus = (
   proposal: TransactionAccount | undefined,

governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/utils.ts

@@ -10,6 +10,8 @@
     "pull:env": "[ $CI ] || VERCEL_ORG_ID=team_BKQrg3JJFLxZyTqpuYtIY0rj VERCEL_PROJECT_ID=prj_TCjesnm3pxM7Ay8oxlTH4xLkkmP9 vercel env pull",
     "start:dev": "next dev --port 3004",
     "start:prod": "next start --port 3004",
+    "test:format": "prettier --check .",
+    "fix:format": "prettier --write .",
     "test:lint": "next lint --max-warnings 0"
   },
   "dependencies": {

governance/xc_admin/packages/xc_admin_frontend/package.json

@@ -3,27 +3,14 @@
   "extends": ["//"],
   "tasks": {
     "build": {
-      "dependsOn": ["pull:env", "^build"],
-      "outputs": [".next/**", "!.next/cache/**"],
       "env": [
         "BUILD_STANDALONE",
         "NEXT_PUBLIC_MAINNET_RPC",
         "NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID"
       ]
     },
-    "pull:env": {
-      "outputs": [".env.local"],
-      "cache": false
-    },
     "start:dev": {
-      "dependsOn": ["pull:env", "^build"],
-      "persistent": true,
-      "cache": false
-    },
-    "start:prod": {
-      "dependsOn": ["build"],
-      "persistent": true,
-      "cache": false
+      "dependsOn": ["//#install:modules", "pull:env", "^build"]
     }
   }
 }

governance/xc_admin/packages/xc_admin_frontend/turbo.json

@@ -2,9 +2,6 @@
   "$schema": "https://turbo.build/schema.json",
   "extends": ["//"],
   "tasks": {
-    "test": {
-      "dependsOn": ["test:format"]
-    },
     "test:anchor": {}
   }
 }

lazer/contracts/solana/turbo.json

@@ -10,7 +10,7 @@ const client = await PythLazerClient.create(
   ["wss://pyth-lazer.dourolabs.app/v1/stream"],
   "access_token",
   3, // Optionally specify number of parallel redundant connections to reduce the chance of dropped messages. The connections will round-robin across the provided URLs. Default is 3.
-  console // Optionally log socket operations (to the console in this case.)
+  console, // Optionally log socket operations (to the console in this case.)
 );
 
 // Read and process messages from the Lazer stream
@@ -23,7 +23,7 @@ client.addMessageListener((message) => {
           "stream updated for subscription",
           message.value.subscriptionId,
           ":",
-          message.value.parsed?.priceFeeds
+          message.value.parsed?.priceFeeds,
         );
       }
       break;

lazer/sdk/js/examples/index.ts

@@ -26,6 +26,8 @@
     "fix:lint": "eslint --fix . --max-warnings 0",
     "test:lint": "eslint . --max-warnings 0",
     "test:types": "tsc",
+    "test:format": "prettier --check .",
+    "fix:format": "prettier --write .",
     "example": "node --loader ts-node/esm examples/index.js",
     "doc": "typedoc --out docs/typedoc src",
     "publish": "pnpm run script -- publish"