Skip to content

Commit d68155e

Browse files
committed
fix test
1 parent 0b4d34a commit d68155e

File tree

2 files changed

+1
-39
lines changed

2 files changed

+1
-39
lines changed

target_chains/ethereum/contracts/contracts/pulse/PulseErrors.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@ error CallbackFailed();
1111
error InvalidPriceIds(bytes32 providedPriceIdsHash, bytes32 storedPriceIdsHash);
1212
error InvalidCallbackGasLimit(uint256 requested, uint256 stored);
1313
error ExceedsMaxPrices(uint32 requested, uint32 maxAllowed);
14-
error InsufficientGas();
1514
error TooManyPriceIds(uint256 provided, uint256 maximum);

target_chains/ethereum/contracts/forge-test/Pulse.t.sol

Lines changed: 1 addition & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ contract PulseTest is Test, PulseEvents {
414414

415415
// Try executing with only 100K gas when 1M is required
416416
vm.prank(defaultProvider);
417-
vm.expectRevert(InsufficientGas.selector);
417+
vm.expectRevert(); // Just expect any revert since it will be an out-of-gas error
418418
pulse.executeCallback{gas: 100000}(
419419
sequenceNumber,
420420
updateData,
@@ -669,43 +669,6 @@ contract PulseTest is Test, PulseEvents {
669669
pulse.executeCallback(sequenceNumber, updateData, wrongPriceIds);
670670
}
671671

672-
function testExecuteCallbackGasOverhead() public {
673-
// Setup request with 1M gas limit
674-
(
675-
uint64 sequenceNumber,
676-
bytes32[] memory priceIds,
677-
uint256 publishTime
678-
) = setupConsumerRequest(address(consumer), defaultProvider);
679-
680-
// Setup mock data
681-
PythStructs.PriceFeed[] memory priceFeeds = createMockPriceFeeds(
682-
publishTime
683-
);
684-
mockParsePriceFeedUpdates(priceFeeds);
685-
bytes[] memory updateData = createMockUpdateData(priceFeeds);
686-
687-
// Should fail with exactly 1.4x gas (less than required 1.5x)
688-
vm.prank(defaultProvider);
689-
vm.expectRevert(InsufficientGas.selector);
690-
pulse.executeCallback{gas: (CALLBACK_GAS_LIMIT * 14) / 10}(
691-
sequenceNumber,
692-
updateData,
693-
priceIds
694-
);
695-
696-
// Should succeed with 1.6x gas
697-
vm.prank(defaultProvider);
698-
pulse.executeCallback{gas: (CALLBACK_GAS_LIMIT * 16) / 10}(
699-
sequenceNumber,
700-
updateData,
701-
priceIds
702-
);
703-
704-
// Verify callback was executed successfully
705-
assertEq(consumer.lastSequenceNumber(), sequenceNumber);
706-
assertEq(consumer.lastProvider(), defaultProvider);
707-
}
708-
709672
function testRevertOnTooManyPriceIds() public {
710673
uint256 maxPriceIds = uint256(pulse.MAX_PRICE_IDS());
711674
// Create array with MAX_PRICE_IDS + 1 price IDs

0 commit comments

Comments
 (0)