resolved comments

aditya520 · aditya520 · commit 72f3f56007f2 · 2024-03-28T17:17:09.000-04:00
diff --git a/target_chains/ethereum/contracts/forge-test/utils/PythTestUtils.t.sol b/target_chains/ethereum/contracts/forge-test/utils/PythTestUtils.t.sol
@@ -277,12 +277,7 @@ abstract contract PythTestUtils is Test, WormholeTestUtils, RandTestUtils {
     }
 }
 
-contract PythTestUtilsTest is
-    Test,
-    WormholeTestUtils,
-    PythTestUtils,
-    IPythEvents
-{
+contract PythUtilsTest is Test, WormholeTestUtils, PythTestUtils, IPythEvents {
     function testConvertToUnit() public {
         // Price can't be negative
         vm.expectRevert();
diff --git a/target_chains/ethereum/sdk/solidity/PythUtils.sol b/target_chains/ethereum/sdk/solidity/PythUtils.sol
@@ -7,7 +7,8 @@ library PythUtils {
     /// @param expo The Pyth price exponent
     /// @param targetDecimals The target number of decimals
     /// @return The price as a uint256
-    /// @dev Function will loose precision if targetDecimals is less than the Pyth price decimals
+    /// @dev Function will lose precision if targetDecimals is less than the Pyth price decimals.
+    /// This method will truncate any digits that cannot be represented by the targetDecimals.
     /// e.g. If the price is 0.000123 and the targetDecimals is 2, the result will be 0
     function convertToUint(
         int64 price,

Original file line number	Diff line number	Diff line change
`@@ -277,12 +277,7 @@ abstract contract PythTestUtils is Test, WormholeTestUtils, RandTestUtils {`
`277`	`277`	`}`
`278`	`278`	`}`
`279`	`279`
`280`		`-contract PythTestUtilsTest is`
`281`		`- Test,`
`282`		`- WormholeTestUtils,`
`283`		`- PythTestUtils,`
`284`		`- IPythEvents`
`285`		`-{`
	`280`	`+contract PythUtilsTest is Test, WormholeTestUtils, PythTestUtils, IPythEvents {`
`286`	`281`	`function testConvertToUnit() public {`
`287`	`282`	`// Price can't be negative`
`288`	`283`	`vm.expectRevert();`